This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objcopy] [COFF] Test absolute symbols wrt --strip-unneeded and --discard-all. NFC.
ClosedPublic

Authored by mstorsjo on Jan 14 2019, 5:00 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Jan 14 2019, 5:00 AM
jhenderson accepted this revision.Jan 14 2019, 5:35 AM

LGTM. I'm assuming that the -1 SectionNumber is what makes them absolute?

This revision is now accepted and ready to land.Jan 14 2019, 5:35 AM

LGTM. I'm assuming that the -1 SectionNumber is what makes them absolute?

Exactly - section indices are positive for actual defined sections, zero for undefined and negative for a few special cases. (-1 for absolute and -2 for a debug kind of symbol.)

This revision was automatically updated to reflect the committed changes.