This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objcopy] [COFF] Test absolute symbols wrt --strip-unneeded and --discard-all. NFC.
ClosedPublic

Authored by mstorsjo on Jan 14 2019, 5:00 AM.

Download Raw Diff

Details

Reviewers

jhenderson
alexander-shaposhnikov
rupprecht
jakehehrlich
rnk

Commits

rG4707fb65d488: [llvm-objcopy] [COFF] Test absolute symbols wrt --strip-unneeded and --discard…
rL351098: [llvm-objcopy] [COFF] Test absolute symbols wrt --strip-unneeded and --discard…

Summary

These seem to be handled correctly vs GNU objcopy as the code stands right now.

Diff Detail

Event Timeline

mstorsjo created this revision.Jan 14 2019, 5:00 AM

LGTM. I'm assuming that the -1 SectionNumber is what makes them absolute?

This revision is now accepted and ready to land.Jan 14 2019, 5:35 AM

In D56659#1356023, @jhenderson wrote:

LGTM. I'm assuming that the -1 SectionNumber is what makes them absolute?

Exactly - section indices are positive for actual defined sections, zero for undefined and negative for a few special cases. (-1 for absolute and -2 for a debug kind of symbol.)

Closed by commit rL351098: [llvm-objcopy] [COFF] Test absolute symbols wrt --strip-unneeded and --discard… (authored by mstorsjo). · Explain WhyJan 14 2019, 11:00 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

test/

tools/

llvm-objcopy/

COFF/

Inputs/

discard-locals.yaml

6 lines

discard-all.test

1 line

strip-unneeded.test

1 line

Diff 181536

test/tools/llvm-objcopy/COFF/Inputs/discard-locals.yaml

Show All 36 Lines	- Name: local_referenced
ComplexType: IMAGE_SYM_DTYPE_NULL		ComplexType: IMAGE_SYM_DTYPE_NULL
StorageClass: IMAGE_SYM_CLASS_STATIC		StorageClass: IMAGE_SYM_CLASS_STATIC
- Name: local_undefined_unreferenced		- Name: local_undefined_unreferenced
Value: 0		Value: 0
SectionNumber: 0		SectionNumber: 0
SimpleType: IMAGE_SYM_TYPE_NULL		SimpleType: IMAGE_SYM_TYPE_NULL
ComplexType: IMAGE_SYM_DTYPE_NULL		ComplexType: IMAGE_SYM_DTYPE_NULL
StorageClass: IMAGE_SYM_CLASS_STATIC		StorageClass: IMAGE_SYM_CLASS_STATIC
		- Name: '@feat.00'
		Value: 0
		SectionNumber: -1
		SimpleType: IMAGE_SYM_TYPE_NULL
		ComplexType: IMAGE_SYM_DTYPE_NULL
		StorageClass: IMAGE_SYM_CLASS_STATIC
...		...

test/tools/llvm-objcopy/COFF/discard-all.test

	Show All 16 Lines
	RUN: cmp %t.out.o %t.strip-discard-all.o			RUN: cmp %t.out.o %t.strip-discard-all.o

	SYMBOLS: SYMBOL TABLE:			SYMBOLS: SYMBOL TABLE:
	SYMBOLS-NEXT: external			SYMBOLS-NEXT: external
	SYMBOLS-NEXT: external_undefined			SYMBOLS-NEXT: external_undefined
	SYMBOLS-PRE-NEXT: local_unreferenced			SYMBOLS-PRE-NEXT: local_unreferenced
	SYMBOLS-NEXT: local_referenced			SYMBOLS-NEXT: local_referenced
	SYMBOLS-NEXT: local_undefined_unreferenced			SYMBOLS-NEXT: local_undefined_unreferenced
				SYMBOLS-PRE-NEXT: @feat.00
	SYMBOLS-EMPTY:			SYMBOLS-EMPTY:

test/tools/llvm-objcopy/COFF/strip-unneeded.test

	RUN: yaml2obj %p/Inputs/discard-locals.yaml > %t.in.o			RUN: yaml2obj %p/Inputs/discard-locals.yaml > %t.in.o

	RUN: llvm-objdump -t %t.in.o \| FileCheck %s --check-prefixes=SYMBOLS,SYMBOLS-PRE			RUN: llvm-objdump -t %t.in.o \| FileCheck %s --check-prefixes=SYMBOLS,SYMBOLS-PRE

	RUN: llvm-objcopy --strip-unneeded %t.in.o %t.out.o			RUN: llvm-objcopy --strip-unneeded %t.in.o %t.out.o
	RUN: llvm-objdump -t %t.out.o \| FileCheck %s --check-prefix=SYMBOLS			RUN: llvm-objdump -t %t.out.o \| FileCheck %s --check-prefix=SYMBOLS

	SYMBOLS: SYMBOL TABLE:			SYMBOLS: SYMBOL TABLE:
	SYMBOLS-NEXT: external			SYMBOLS-NEXT: external
	SYMBOLS-NEXT: external_undefined			SYMBOLS-NEXT: external_undefined
	SYMBOLS-PRE-NEXT: local_unreferenced			SYMBOLS-PRE-NEXT: local_unreferenced
	SYMBOLS-NEXT: local_referenced			SYMBOLS-NEXT: local_referenced
	SYMBOLS-PRE-NEXT: local_undefined_unreferenced			SYMBOLS-PRE-NEXT: local_undefined_unreferenced
				SYMBOLS-PRE-NEXT: @feat.00
	SYMBOLS-EMPTY:			SYMBOLS-EMPTY: