Page MenuHomePhabricator

gn build: Unbreak Windows build
ClosedPublic

Authored by thakis on Jan 11 2019, 6:27 PM.

Details

Summary

I didn't break all that much during upstreaming, just needs two small fixes:

  • fix spelling of MCJITTests.def file
  • make libLTO a shared_library to put it in bin/ on Windows where it is in the CMake build too

Diff Detail

Event Timeline

thakis created this revision.Jan 11 2019, 6:27 PM
phosek accepted this revision.Jan 11 2019, 8:13 PM

LGTM

This revision is now accepted and ready to land.Jan 11 2019, 8:13 PM
Closed by commit rL351004: gn build: Unbreak Windows build (authored by nico, committed by ). · Explain WhyJan 12 2019, 4:01 AM
This revision was automatically updated to reflect the committed changes.