This is an archive of the discontinued LLVM Phabricator instance.

gn build: Stop defining LLVM_ON_UNIX globally.
ClosedPublic

Authored by pcc on Jan 11 2019, 5:37 PM.

Reviewers

phosek
thakis

Commits

Summary

This macro is already being defined in llvm-config.h.

Repository

rL LLVM

Build Status

Buildable 26737
Build 26736: arc lint + arc unit

Ah right, this from before I generated llvm-config.h long long ago. Well, that was easy :-)

This revision is now accepted and ready to land.Jan 11 2019, 6:24 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

utils/

gn/

build/

5 lines

	import("//llvm/utils/gn/build/buildflags.gni")			import("//llvm/utils/gn/build/buildflags.gni")
	import("//llvm/utils/gn/build/mac_sdk.gni")			import("//llvm/utils/gn/build/mac_sdk.gni")
	import("//llvm/utils/gn/build/toolchain/compiler.gni")			import("//llvm/utils/gn/build/toolchain/compiler.gni")

	config("compiler_defaults") {			config("compiler_defaults") {
	defines = []			defines = []

	# FIXME: Don't define this globally here.
	if (host_os != "win") {
	defines += [ "LLVM_ON_UNIX" ]
	}

	if (!llvm_enable_assertions) {			if (!llvm_enable_assertions) {
	defines += [ "NDEBUG" ]			defines += [ "NDEBUG" ]
	}			}

	cflags = []			cflags = []

	if (host_os == "mac" && clang_base_path != "") {			if (host_os == "mac" && clang_base_path != "") {
	cflags += [			cflags += [
	▲ Show 20 Lines • Show All 123 Lines • Show Last 20 Lines