Page MenuHomePhabricator

gn build: Create a template for unix toolchains.
ClosedPublic

Authored by pcc on Jan 10 2019, 9:35 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

pcc created this revision.Jan 10 2019, 9:35 PM
thakis accepted this revision.Jan 11 2019, 6:32 AM

lgtm!

llvm/utils/gn/build/toolchain/BUILD.gn
37 ↗(On Diff #181207)

Please mention the host_os->current_os change in this file in the CL description too.

140 ↗(On Diff #181207)

Should we set current_os in the win toolchain too? OK to defer that until we actually need it too, but the failure mode for not having it here and trying to use current_os in a cross build involving a win toolchain is probably a bit confusing unless you know what's needed to fix it.

This revision is now accepted and ready to land.Jan 11 2019, 6:32 AM
pcc marked 3 inline comments as done.Jan 11 2019, 3:01 PM
pcc added inline comments.
llvm/utils/gn/build/toolchain/BUILD.gn
140 ↗(On Diff #181207)

Makes sense, done.

This revision was automatically updated to reflect the committed changes.
pcc marked an inline comment as done.