Page MenuHomePhabricator

[opaque pointer types] Update InvokeInst creation APIs to consistently accept a callee-type argument.
ClosedPublic

Authored by jyknight on Jan 10 2019, 1:22 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

jyknight created this revision.Jan 10 2019, 1:22 PM
jyknight updated this revision to Diff 181153.Jan 10 2019, 2:07 PM

(Ran clang format; forgot to do before uploading before)

whitequark requested changes to this revision.Jan 10 2019, 7:35 PM
whitequark added inline comments.
llvm/include/llvm-c/Core.h
3411 ↗(On Diff #181153)

Please add NameLen as this is the convention for all new C APIs.

This revision now requires changes to proceed.Jan 10 2019, 7:35 PM
whitequark added inline comments.Jan 10 2019, 7:40 PM
llvm/include/llvm-c/Core.h
3411 ↗(On Diff #181153)

(See discussion over at https://reviews.llvm.org/D56556#1353734).

niravd accepted this revision.Jan 14 2019, 12:09 PM
niravd added a subscriber: niravd.

LGTM.

This revision was not accepted when it landed; it landed in state Needs Revision.Jan 14 2019, 1:41 PM
This revision was automatically updated to reflect the committed changes.