This is an archive of the discontinued LLVM Phabricator instance.

Differential D56522

[SemaCXX] add -Woverride-init alias to -Winitializer-overrides
ClosedPublic

Authored by nickdesaulniers on Jan 9 2019, 4:37 PM.

Details

Reviewers
rsmith
Commits
rG2383aad54054: [SemaCXX] add -Woverride-init alias to -Winitializer-overrides
rC350877: [SemaCXX] add -Woverride-init alias to -Winitializer-overrides
rL350877: [SemaCXX] add -Woverride-init alias to -Winitializer-overrides
Summary

https://bugs.llvm.org/show_bug.cgi?id=40251
https://github.com/ClangBuiltLinux/linux/issues/307

Diff Detail

Repository
rL LLVM

Event Timeline

nickdesaulniers created this revision.Jan 9 2019, 4:37 PM
Herald added a subscriber: cfe-commits. · View Herald TranscriptJan 9 2019, 4:37 PM
Harbormaster completed remote builds in B26608: Diff 180962.Jan 9 2019, 4:37 PM
rsmith accepted this revision.Jan 9 2019, 5:22 PM
rsmith added inline comments.
include/clang/Basic/DiagnosticGroups.td
364 ↗(On Diff #180962)

Please note that this is for GCC compatibility in this comment.

This revision is now accepted and ready to land.Jan 9 2019, 5:22 PM
nickdesaulniers updated this revision to Diff 181108.Jan 10 2019, 11:08 AM
  • add gcc compat comment
nickdesaulniers marked an inline comment as done.Jan 10 2019, 11:08 AM
Harbormaster completed remote builds in B26647: Diff 181108.Jan 10 2019, 11:09 AM
Closed by commit rL350877: [SemaCXX] add -Woverride-init alias to -Winitializer-overrides (authored by nickdesaulniers). · Explain WhyJan 10 2019, 11:18 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptJan 10 2019, 11:18 AM

Revision Contents

PathSize
cfe/
trunk/
docs/
4 lines
include/
clang/
Basic/
2 lines
test/
SemaCXX/
1 line

Diff 181113

cfe/trunk/docs/DiagnosticsReference.rst

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 7,879 Lines • ▼ Show 20 Lines
+-----------------------------------------------------------------------------------------------+-----------------------+ +-----------------------------------------------------------------------------------------------+-----------------------+
|:warning:`warning:` |nbsp| :placeholder:`A` |nbsp| :diagtext:`hides overloaded virtual` |nbsp| |+---------------------+| |:warning:`warning:` |nbsp| :placeholder:`A` |nbsp| :diagtext:`hides overloaded virtual` |nbsp| |+---------------------+|
| ||:diagtext:`function` || | ||:diagtext:`function` ||
| |+---------------------+| | |+---------------------+|
| ||:diagtext:`functions`|| | ||:diagtext:`functions`||
| |+---------------------+| | |+---------------------+|
+-----------------------------------------------------------------------------------------------+-----------------------+ +-----------------------------------------------------------------------------------------------+-----------------------+
-Woverride-init
--------------
Synonym for `-Winitializer-overrides`_.
-Woverride-module -Woverride-module
----------------- -----------------
This diagnostic is enabled by default. This diagnostic is enabled by default.
**Diagnostic text:** **Diagnostic text:**
+-------------------------------------------------------------------------------------------------------+ +-------------------------------------------------------------------------------------------------------+
▲ Show 20 Lines • Show All 3,693 Lines • Show Last 20 Lines

cfe/trunk/include/clang/Basic/DiagnosticGroups.td

Show First 20 Lines • Show All 359 Lines • ▼ Show 20 Lines
def NullableToNonNullConversion : DiagGroup<"nullable-to-nonnull-conversion">; def NullableToNonNullConversion : DiagGroup<"nullable-to-nonnull-conversion">;
def NullabilityCompletenessOnArrays : DiagGroup<"nullability-completeness-on-arrays">; def NullabilityCompletenessOnArrays : DiagGroup<"nullability-completeness-on-arrays">;
def NullabilityCompleteness : DiagGroup<"nullability-completeness", def NullabilityCompleteness : DiagGroup<"nullability-completeness",
[NullabilityCompletenessOnArrays]>; [NullabilityCompletenessOnArrays]>;
def NullArithmetic : DiagGroup<"null-arithmetic">; def NullArithmetic : DiagGroup<"null-arithmetic">;
def NullCharacter : DiagGroup<"null-character">; def NullCharacter : DiagGroup<"null-character">;
def NullDereference : DiagGroup<"null-dereference">; def NullDereference : DiagGroup<"null-dereference">;
def InitializerOverrides : DiagGroup<"initializer-overrides">; def InitializerOverrides : DiagGroup<"initializer-overrides">;
// For compatibility with GCC; -Woverride-init = -Winitializer-overrides
def : DiagGroup<"override-init", [InitializerOverrides]>;
def NonNull : DiagGroup<"nonnull">; def NonNull : DiagGroup<"nonnull">;
def NonPODVarargs : DiagGroup<"non-pod-varargs">; def NonPODVarargs : DiagGroup<"non-pod-varargs">;
def ClassVarargs : DiagGroup<"class-varargs", [NonPODVarargs]>; def ClassVarargs : DiagGroup<"class-varargs", [NonPODVarargs]>;
def : DiagGroup<"nonportable-cfstrings">; def : DiagGroup<"nonportable-cfstrings">;
def NonVirtualDtor : DiagGroup<"non-virtual-dtor">; def NonVirtualDtor : DiagGroup<"non-virtual-dtor">;
def NullPointerArithmetic : DiagGroup<"null-pointer-arithmetic">; def NullPointerArithmetic : DiagGroup<"null-pointer-arithmetic">;
def : DiagGroup<"effc++", [NonVirtualDtor]>; def : DiagGroup<"effc++", [NonVirtualDtor]>;
def OveralignedType : DiagGroup<"over-aligned">; def OveralignedType : DiagGroup<"over-aligned">;
▲ Show 20 Lines • Show All 675 Lines • Show Last 20 Lines

cfe/trunk/test/SemaCXX/designated-initializers.cpp

// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify -Winitializer-overrides %s // RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify -Winitializer-overrides %s
// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify -Woverride-init %s
template <typename T> struct Foo { template <typename T> struct Foo {
struct SubFoo { struct SubFoo {
int bar1; int bar1;
int bar2; int bar2;
}; };
static void Test() { SubFoo sf = {.bar1 = 10, .bar2 = 20}; } // Expected no warning static void Test() { SubFoo sf = {.bar1 = 10, .bar2 = 20}; } // Expected no warning
Show All 22 Lines