This is an archive of the discontinued LLVM Phabricator instance.

gn build: Fix a Python2ism in write_vcsrevision.py.
ClosedPublic

Authored by pcc on Jan 8 2019, 3:56 PM.

Details

Summary

Convert the output of "git rev-parse --short HEAD" to a string before
substituting it into the output file. Without this the output file
will look like this on Python 3:

#define LLVM_REVISION "git-b'6a4895a025f'"

Diff Detail

Event Timeline

pcc created this revision.Jan 8 2019, 3:56 PM
phosek accepted this revision.Jan 8 2019, 6:45 PM

LGTM

This revision is now accepted and ready to land.Jan 8 2019, 6:45 PM
This revision was automatically updated to reflect the committed changes.