Most significantly, this makes bin/llvm-lit executable so that it
can be run in the usual way.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
llvm/utils/gn/build/write_cmake_config.py | ||
---|---|---|
105 ↗ | (On Diff #180599) | Shouldn't this be inside the if block so the permissions are only changed if file is actually written? |
llvm/utils/gn/build/write_cmake_config.py | ||
---|---|---|
105 ↗ | (On Diff #180599) | I thought about doing it that way, but figured that we'd want to copy the permissions if the contents don't change but the permissions do. Admittedly this is a bit of an edge case and now that I think about it more I don't even think that ninja will rerun the command in that case. So it would probably be slightly better to move it inside so that we don't disturb the ctime if the file didn't change. I'll do that. |