Page MenuHomePhabricator

Implement the TreeStructure interface through the TextNodeDumper
ClosedPublic

Authored by steveire on Mon, Jan 7, 1:15 PM.

Details

Summary

This way, when the generic ASTTraverser is extracted from ASTDumper,
there can't be any problem related to ordering of class members, a
concern that was raised in https://reviews.llvm.org/D55337.

This will also preserve the property that the generic traverser does not
enforce any coupling between the NodeDumper and the TreeStructure.

https://godbolt.org/z/PEtT1_

Diff Detail

Repository
rC Clang

Event Timeline

steveire created this revision.Mon, Jan 7, 1:15 PM
aaron.ballman accepted this revision.Tue, Jan 8, 7:15 AM

I think this is a good approach to solving the problem, so let's go this route.

This revision is now accepted and ready to land.Tue, Jan 8, 7:15 AM

I think this is a good approach to solving the problem, so let's go this route.

Yeah, I agree here. This ends up being a really clean solution.

This revision was automatically updated to reflect the committed changes.