GlobalISel: Remove invalid assert

[arsenm]

Summary

G_CONSTANT is allowed for vectors

[arsenm]

This also needs to happen in buildFConstant

[aditya_nandakumar]

LGTM.

[aditya_nandakumar]

While splatting is convenient (compared with build_vector of constants), I realized from discussion in https://reviews.llvm.org/D56379, this would make it inconsistent with rest of GISel.

[arsenm]

D56835

lib/CodeGen/GlobalISel/MachineIRBuilder.cpp

MachineInstrBuilder MachineIRBuilder::buildCopy(const DstOp &Res,
                                                 const SrcOp &Op) {
   return buildInstr(TargetOpcode::COPY, Res, Op);
 }
 
 MachineInstrBuilder MachineIRBuilder::buildConstant(const DstOp &Res,
                                                     const ConstantInt &Val) {
   LLT Ty = Res.getLLTTy(*getMRI());
 
-  assert((Ty.isScalar() || Ty.isPointer()) && "invalid operand type");
-
   const ConstantInt *NewVal = &Val;
-  if (Ty.getSizeInBits() != Val.getBitWidth())
+  if (Ty.getScalarSizeInBits() != Val.getBitWidth())
     NewVal = ConstantInt::get(getMF().getFunction().getContext(),
                               Val.getValue().sextOrTrunc(Ty.getSizeInBits()));
 
   auto MIB = buildInstr(TargetOpcode::G_CONSTANT);
   Res.addDefToMIB(*getMRI(), MIB);
   MIB.addCImm(NewVal);
   return MIB;
 }