Page MenuHomePhabricator

[MemorySSA] Add SkipSelfWalker.
ClosedPublic

Authored by asbirlea on Jan 3 2019, 11:58 AM.

Details

Diff Detail

Repository
rL LLVM

Event Timeline

asbirlea created this revision.Jan 3 2019, 11:58 AM
george.burgess.iv accepted this revision.Jan 3 2019, 1:40 PM

LGTM modulo a naming nit. If you're happy with the suggestion, feel free to submit. Thanks!

include/llvm/Analysis/MemorySSA.h
890 ↗(On Diff #180117)

Nit: Why not call this SkipSelfWalker? (and getSkipSelfWalker())?

This revision is now accepted and ready to land.Jan 3 2019, 1:40 PM
asbirlea marked an inline comment as done.Jan 3 2019, 4:16 PM
asbirlea added inline comments.
include/llvm/Analysis/MemorySSA.h
890 ↗(On Diff #180117)

I agree with getSkipSelfWalker(), but the variable name will clash with the class name. Perhaps SkipWalker instead?

include/llvm/Analysis/MemorySSA.h
890 ↗(On Diff #180117)

Good call; WFM

This revision was automatically updated to reflect the committed changes.