Page MenuHomePhabricator

python compat - print statement
ClosedPublic

Authored by serge-sans-paille on Thu, Jan 3, 3:18 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

Can you please submit the google benchmark diff separately, and submit it upstream at the same time, please?

michaelplatings requested changes to this revision.Thu, Jan 3, 5:23 AM
michaelplatings added inline comments.
examples/Kaleidoscope/MCJIT/cached/split-lib.py
3 ↗(On Diff #180012)

missing underscore

This revision now requires changes to proceed.Thu, Jan 3, 5:23 AM

@lebedev.ri : it turns out the only print statement in the two files involved in gbench only have one argument, and they already have the required parethesis. This means that as such, even without the import from future, they work the same in Python2 and Python3. So I will just remove these imports to avoid extra noise.

serge-sans-paille marked an inline comment as done.
This revision is now accepted and ready to land.Thu, Jan 3, 6:04 AM
Closed by commit rL350307: Python compat - print statement (authored by serge_sans_paille, committed by ). · Explain WhyThu, Jan 3, 6:15 AM
This revision was automatically updated to reflect the committed changes.