Details
Diff Detail
Event Timeline
clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp | ||
---|---|---|
535 | Mmm, what does L stand for here? | |
541–545 | std::any_of()? | |
clang/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp | ||
842 | Typo: "because". | |
clang/test/Analysis/osobject-retain-release.cpp | ||
114 | Should we somehow indicate that we assumed that the function returns a success value? I.e., bug visitor / tag. Also what is the intended behavior if we replace write_into_out_param_on_success with write_into_out_param_on_failure here? | |
114 | That is, i really want this test added, and then it's good to commit, other nits are minor. |
clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp | ||
---|---|---|
535 | vaLue. | |
541–545 | That's super verbose with iterators and requires putting those values in the array. <template T, template Others...> bool isAnyOf(T Val, Others... OtherVals) function |
Yay thx.
clang/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.cpp | ||
---|---|---|
535 | L usually stands for Loc; V is more common for raw SVals. |
Mmm, what does L stand for here?