Page MenuHomePhabricator

[analyzer] [RetainCountChecker] [NFC] Remove SummaryLog
ClosedPublic

Authored by george.karpenkov on Jan 2 2019, 3:47 PM.

Details

Summary

The complicated machinery for passing the summary log around is actually only used for one thing! To figure out whether the "dealloc" message was sent.

Since I have tried to extend it for other uses and failed (it's actually very hard to use), I think it's much better to simply use a tag and remove the summary log altogether.

Diff Detail

Repository
rL LLVM

Event Timeline

NoQ accepted this revision.Jan 2 2019, 10:31 PM

Ugh, how did that make it in t__t

This revision is now accepted and ready to land.Jan 2 2019, 10:31 PM
NoQ added a comment.Jan 2 2019, 10:54 PM

I guess this is something that's usually done via a visitor, but also implementing visitors via tags is something i would definitely like to try out.

This revision was automatically updated to reflect the committed changes.