This is an archive of the discontinued LLVM Phabricator instance.

[gn build] Add some llvm/tools: lli, lli-child-target
ClosedPublic

Authored by thakis on Jan 1 2019, 5:32 PM.

Details

Summary

Also add build files for dependencies llvm/lib/ExecutionEngine/{Interpreter,Orc}

Diff Detail

Repository
rL LLVM

Event Timeline

thakis created this revision.Jan 1 2019, 5:32 PM
phosek added inline comments.Jan 1 2019, 7:42 PM
llvm/utils/gn/secondary/BUILD.gn
11 ↗(On Diff #179808)

You seem to be overriding the name of the target to match the name of the directory and then setting the output_name explicitly everywhere. Is there a reason why not to use the same approach here as well?

thakis marked an inline comment as done.Jan 1 2019, 7:45 PM
thakis added inline comments.
llvm/utils/gn/secondary/BUILD.gn
11 ↗(On Diff #179808)

I do that for static_libraries but not for executables (other example I can think of: clang/tools/driver:clang). I can change it to use output_name here if you prefer.

phosek accepted this revision.Jan 2 2019, 9:32 AM

LGTM

This revision is now accepted and ready to land.Jan 2 2019, 9:32 AM
This revision was automatically updated to reflect the committed changes.