Page MenuHomePhabricator

[sanitizer_common] Implement funopen*() interceptors for NetBSD
ClosedPublic

Authored by mgorny on Dec 29 2018, 3:17 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

mgorny created this revision.Dec 29 2018, 3:17 PM
Herald added subscribers: Restricted Project, llvm-commits, kubamracek. · View Herald TranscriptDec 29 2018, 3:17 PM

Shouldn't this follow SANITIZER_INTERCEPT_FOPENCOOKIE and implement a wrapper for operations?

mgorny updated this revision to Diff 179722.Dec 30 2018, 4:13 AM

Implemented wrappers as requested.

mgorny updated this revision to Diff 179723.Dec 30 2018, 4:14 AM

Fixed accidental whitespace change.

krytarowski added inline comments.Dec 30 2018, 6:51 AM
lib/sanitizer_common/sanitizer_common_interceptors.inc
9142 ↗(On Diff #179723)

I would call it WrappedFunopenCookie to be less generic, similarly for funopen2.

krytarowski added inline comments.Dec 30 2018, 7:01 AM
lib/sanitizer_common/sanitizer_common_interceptors.inc
9150 ↗(On Diff #179723)

How about wrapped_funopen_read etc? It won't clash with future potential inteceptors with so generic names.

mgorny updated this revision to Diff 179728.Dec 30 2018, 7:17 AM

Renamed stuff as requested.

krytarowski accepted this revision.Dec 30 2018, 7:23 AM
This revision is now accepted and ready to land.Dec 30 2018, 7:23 AM
This revision was automatically updated to reflect the committed changes.