Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[sanitizer_common] Add test for popen()

Authored by mgorny on Dec 29 2018, 10:53 AM.

Diff Detail


Event Timeline

mgorny created this revision.Dec 29 2018, 10:53 AM

It looks fine, but we don't have interceptors for popen(3), popenve(3), pclose(3). Could you include them together with this patch? Add add a test for popenve(3).

krytarowski accepted this revision.Dec 29 2018, 11:57 AM

But of course new code can be added as a new revision.

This revision is now accepted and ready to land.Dec 29 2018, 11:57 AM
mgorny updated this revision to Diff 179712.Dec 29 2018, 2:49 PM

Added assertion verifying that fileno(fp) works.

This revision was automatically updated to reflect the committed changes.