Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D56049

[compiler-rt] [xray] Detect MPROTECT and error out when it's enabled (on NetBSD)
ClosedPublic
Actions

Authored by mgorny on Dec 22 2018, 2:53 AM.

Details

Reviewers
krytarowski
dberris
Commits
rGa939b40eae39: [xray] Detect MPROTECT and error out when it's enabled (on NetBSD)
rCRT350030: [xray] Detect MPROTECT and error out when it's enabled (on NetBSD)
rL350030: [xray] Detect MPROTECT and error out when it's enabled (on NetBSD)
Summary

Add a CheckMPROTECT() routine to detect when pax MPROTECT is enabled
on NetBSD, and error xray out when it is. The solution is adapted
from existing CheckASLR().

Diff Detail

Repository
rL LLVM

Event Timeline

mgorny created this revision.Dec 22 2018, 2:53 AM
Herald added subscribers: Restricted Project, llvm-commits, kubamracek. · View Herald TranscriptDec 22 2018, 2:53 AM
krytarowski accepted this revision.Dec 22 2018, 4:01 AM
krytarowski added inline comments.
lib/xray/xray_init.cc
70 ↗(On Diff #179419)

PaX

This revision is now accepted and ready to land.Dec 22 2018, 4:01 AM
Closed by commit rL350030: [xray] Detect MPROTECT and error out when it's enabled (on NetBSD) (authored by mgorny). · Explain WhyDec 23 2018, 7:13 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: delcypher. · View Herald TranscriptDec 23 2018, 7:14 AM

Revision Contents
Changeset List

PathSize
compiler-rt/
trunk/
lib/
sanitizer_common/
1 line
1 line
24 lines
4 lines
1 line
4 lines
xray/
3 lines

Diff 179444

View Options

compiler-rt/trunk/lib/sanitizer_common/sanitizer_common.h

Loading...
View Options

compiler-rt/trunk/lib/sanitizer_common/sanitizer_fuchsia.cc

Loading...
View Options

compiler-rt/trunk/lib/sanitizer_common/sanitizer_linux.cc

Loading...
View Options

compiler-rt/trunk/lib/sanitizer_common/sanitizer_mac.cc

Loading...
View Options

compiler-rt/trunk/lib/sanitizer_common/sanitizer_rtems.cc

Loading...
View Options

compiler-rt/trunk/lib/sanitizer_common/sanitizer_win.cc

Loading...
View Options

compiler-rt/trunk/lib/xray/xray_init.cc

Loading...