This patch is a follow-up to D55896.
|223 ↗||(On Diff #179376)|
|239 ↗||(On Diff #179376)|
VK_SABS isn't a bit-mask; this technically works because of the specific values of VK_ABS and VK_SABS, but it's very confusing. Please use something like AArch64MCExpr::getSymbolLoc(RefKind) == AArch64MCExpr::VK_SABS instead.
|274 ↗||(On Diff #179376)|
Please use braces consistently for the whole if-else sequence.
|405 ↗||(On Diff #179376)|
We should probably fix getFixupKindInfo() and getFixupKindNumBytes() to correctly account for this bit. Granted, it probably doesn't have much practical effect... I think it'll affect the comments generated by "-show-mc-encoding", and not much else.