This is an archive of the discontinued LLVM Phabricator instance.

Remove dead code.
ClosedPublic

Authored by ruiu on Dec 20 2018, 3:22 PM.

Reviewers

MaskRay
• espindola

Commits

Summary

This code is no-op because of r349849.

Build Status

Buildable 26203
Build 26202: arc lint + arc unit

This revision is now accepted and ready to land.Dec 20 2018, 3:47 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lld/

ELF/

4 lines

Show First 20 Lines • Show All 245 Lines • ▼ Show 20 Lines	Symbol *SymbolTable::addUndefined(StringRef Name, uint8_t Binding,
if (WasInserted \|\| (isa<SharedSymbol>(S) && Visibility != STV_DEFAULT)) {		if (WasInserted \|\| (isa<SharedSymbol>(S) && Visibility != STV_DEFAULT)) {
replaceSymbol<Undefined>(S, File, Name, Binding, StOther, Type);		replaceSymbol<Undefined>(S, File, Name, Binding, StOther, Type);
return S;		return S;
}		}

if (S->isShared() \|\| S->isLazy() \|\| (S->isUndefined() && Binding != STB_WEAK))		if (S->isShared() \|\| S->isLazy() \|\| (S->isUndefined() && Binding != STB_WEAK))
S->Binding = Binding;		S->Binding = Binding;

if (!Config->GcSections && Binding != STB_WEAK)
if (auto *SS = dyn_cast<SharedSymbol>(S))
SS->getFile<ELFT>().IsNeeded = true;

if (S->isLazy()) {		if (S->isLazy()) {
// An undefined weak will not fetch archive members. See comment on Lazy in		// An undefined weak will not fetch archive members. See comment on Lazy in
// Symbols.h for the details.		// Symbols.h for the details.
if (Binding == STB_WEAK) {		if (Binding == STB_WEAK) {
S->Type = Type;		S->Type = Type;
return S;		return S;
}		}

▲ Show 20 Lines • Show All 544 Lines • Show Last 20 Lines