[ELF] Simplify addShared. NFC

[MaskRay]

.

[ruiu]

I already committed something similar. :)

[MaskRay]

.

ELF/SymbolTable.cpp

void SymbolTable::addShared(StringRef Name, SharedFile<ELFT> &File,
   Symbol *S;
   bool WasInserted;
   std::tie(S, WasInserted) = insert(Name, STV_DEFAULT,
                                     /*CanOmitFromDynSym*/ true, &File);
   // Make sure we preempt DSO symbols with default visibility.
   if (Sym.getVisibility() == STV_DEFAULT)
     S->ExportDynamic = true;
 
-  // An undefined symbol with non default visibility must be satisfied
+  if (WasInserted ||
+      // An undefined/lazy symbol with non default visibility must be satisfied
       // in the same DSO.
-  auto Replace = [&](uint8_t Binding) {
+      ((S->isUndefined() || S->isLazy()) && S->Visibility == STV_DEFAULT)) {
+    // Use the original binding if inserted before.
+    uint8_t Binding = WasInserted ? Sym.getBinding() : S->Binding;
     replaceSymbol<SharedSymbol>(S, File, Name, Binding, Sym.st_other,
                                 Sym.getType(), Sym.st_value, Sym.st_size,
                                 Alignment, VerdefIndex);
-  };
-
-  if (WasInserted)
-    Replace(Sym.getBinding());
-  else if (S->Visibility == STV_DEFAULT && (S->isUndefined() || S->isLazy()))
-    Replace(S->Binding);
+  }
 }
 
 Symbol *SymbolTable::addBitcode(StringRef Name, uint8_t Binding,
                                 uint8_t StOther, uint8_t Type,
                                 bool CanOmitFromDynSym, BitcodeFile &F) {
   Symbol *S;
   bool WasInserted;
   std::tie(S, WasInserted) =