This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU/GlobalISel: Redo legality for build_vector
ClosedPublic

Authored by arsenm on Dec 19 2018, 5:30 PM.

Details

Reviewers
tstellar
rampitec
Summary

It seems better to avoid using the callback if possible since
there are coverage assertions which are disabled if this is used.

Also fix missing tests. Only test the legal cases since it seems
legalization for build_vector is quite lacking.

Diff Detail

Event Timeline

arsenm created this revision.Dec 19 2018, 5:30 PM
This revision is now accepted and ready to land.Dec 20 2018, 12:43 AM
arsenm closed this revision.Dec 20 2018, 7:06 PM

r349878