This patch covers subtraction between fixed point types and other fixed point types or integers, using the conversion rules described in 4.1.4 of N1169.
|3451 ↗||(On Diff #180920)|
Please create a separate case for the non-arithmetic operators (pointer-to-member, assignment, comma) that will obviously never end up in this function.
I don't pay attention to "ready to land" because I assume that you're verifying that your patch actually works as promised in practice, at least as far as the tests are concerned (and presumably my review catches deeper issues). If there are substantial changes that landed after my review, then I need to re-review; otherwise, you should feel free to commit with that kind of provisional LGTM when you've satisfied the provisions.