Page MenuHomePhabricator

[Fixed Point Arithmetic] Add APFixedPoint to APValue

Authored by leonardchan on Jan 15 2019, 3:02 PM.

Diff Detail

rC Clang

Event Timeline

Regarding tests, I couldn't actually find any under clang/unittests that test APValue specifically. Is it worth it to add some still?

One nit-pick, then this is good to go.

183 ↗(On Diff #181893)

I know this is the established pattern, but could you just make MakeFixedPoint take a APFixedPoint && and move it into place instead of default-constructing one and then assigning over it?

leonardchan marked an inline comment as done.
rjmccall accepted this revision.Jan 15 2019, 5:16 PM

Thanks, LGTM.

This revision is now accepted and ready to land.Jan 15 2019, 5:16 PM
This revision was automatically updated to reflect the committed changes.