Page MenuHomePhabricator

[llvm-objdump] - Demangle the symbols when printing symbol table and relocations.
ClosedPublic

Authored by grimar on Dec 18 2018, 6:20 AM.

Details

Summary

This is https://bugs.llvm.org/show_bug.cgi?id=40009,

llvm-objdump does not demangle the symbols when prints symbol
table and/or relocations.

Patch teaches it to do that.

Diff Detail

Repository
rL LLVM

Event Timeline

grimar created this revision.Dec 18 2018, 6:20 AM
jhenderson accepted this revision.Dec 18 2018, 7:07 AM

Can you confirm is the following case is covered by this change? Inline listing of relocations when dumping disassembly (i.e. -d -r) also print the symbol name.

LGTM, if it does.

test/tools/llvm-objdump/X86/demangle.s
4 ↗(On Diff #178655)

print -> printing

7 ↗(On Diff #178655)

Ditto.

This revision is now accepted and ready to land.Dec 18 2018, 7:07 AM
grimar updated this revision to Diff 178671.Dec 18 2018, 7:21 AM

Thanks, James! Yes, it works, I updated the test case.

jhenderson accepted this revision.Dec 18 2018, 7:36 AM

Okay, great! LGTM with the updates.

davide accepted this revision.Dec 18 2018, 7:48 AM
This revision was automatically updated to reflect the committed changes.