Page MenuHomePhabricator

Windows ASan: Instrument _msize_base()
ClosedPublic

Authored by vlad.tsyrklevich on Dec 13 2018, 4:07 PM.

Details

Summary

A recent update to the VS toolchain in chromium [1] broke the windows
ASan bot because the new toolchain calls _msize_base() instead of
_msize() in a number of _aligned_* UCRT routines. Instrument
_msize_base() as well.

[1] https://crbug.com/914947

Diff Detail

Event Timeline

vlad.tsyrklevich added reviewers: rnk, Restricted Project.Dec 13 2018, 4:07 PM
vitalybuka accepted this revision.Dec 13 2018, 4:21 PM
vitalybuka added a subscriber: vitalybuka.

LGTM

This revision is now accepted and ready to land.Dec 13 2018, 4:21 PM
rnk accepted this revision.Dec 13 2018, 4:30 PM

lgtm

Thanks for helping in the continual struggle to keep up with new CRT versions.

This revision was automatically updated to reflect the committed changes.