Page MenuHomePhabricator

[libcxx] [regex] Use distinct __regex_word on NetBSD
ClosedPublic

Authored by mgorny on Dec 13 2018, 9:08 AM.

Details

Summary

NetBSD defines character classes up to 0x2000. Use 0x8000 as a safe
__regex_word that hopefully will not collide with other values
in the foreseeable future.

Diff Detail

Repository
rL LLVM

Event Timeline

mgorny created this revision.Dec 13 2018, 9:08 AM

Where and what defines 0x2000, what header and what symbol name?

krytarowski accepted this revision.Dec 13 2018, 12:04 PM

OK, I got it:

#define _CTYPE_Q 0x2000 /* Phonogram */

from /usr/include/sys/ctype_bits.h

I propose to mention the symbol name in the description and the header. In the description is worth to mention the filename of this definition.

This revision is now accepted and ready to land.Dec 13 2018, 12:04 PM
mgorny updated this revision to Diff 178113.Dec 13 2018, 12:08 PM
This revision was automatically updated to reflect the committed changes.