This is an archive of the discontinued LLVM Phabricator instance.

Differential D55610

[libunwind] Avoid code duplication in the SEH version of UnwindCursor::getRegisterName. NFC.
ClosedPublic

Authored by mstorsjo on Dec 12 2018, 12:33 PM.

Details

Reviewers
rnk
compnerd
cdavis5x
mclow.lists
EricWF
ldionne
Commits
rG1ae50897654a: Avoid code duplication in the SEH version of UnwindCursor::getRegisterName. NFC.
rUNW348981: Avoid code duplication in the SEH version of UnwindCursor::getRegisterName. NFC.
rL348981: Avoid code duplication in the SEH version of UnwindCursor::getRegisterName. NFC.
Summary

This requires making Registers_*::getRegisterName static.

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Dec 12 2018, 12:33 PM
Herald added a subscriber: libcxx-commits. · View Herald TranscriptDec 12 2018, 12:33 PM
cdavis5x accepted this revision.Dec 12 2018, 1:33 PM
This revision is now accepted and ready to land.Dec 12 2018, 1:33 PM
mclow.lists accepted this revision.Dec 12 2018, 1:53 PM

LGTM.

Closed by commit rL348981: Avoid code duplication in the SEH version of UnwindCursor::getRegisterName. NFC. (authored by mstorsjo). · Explain WhyDec 12 2018, 2:27 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: christof. · View Herald TranscriptDec 12 2018, 2:27 PM

Revision Contents

PathSize
libunwind/
trunk/
src/
18 lines
108 lines

Diff 177924

libunwind/trunk/src/Registers.hpp

Show All 36 Linespublic:
uint32_t getRegister(int num) const; uint32_t getRegister(int num) const;
void setRegister(int num, uint32_t value); void setRegister(int num, uint32_t value);
bool validFloatRegister(int) const { return false; } bool validFloatRegister(int) const { return false; }
double getFloatRegister(int num) const; double getFloatRegister(int num) const;
void setFloatRegister(int num, double value); void setFloatRegister(int num, double value);
bool validVectorRegister(int) const { return false; } bool validVectorRegister(int) const { return false; }
v128 getVectorRegister(int num) const; v128 getVectorRegister(int num) const;
void setVectorRegister(int num, v128 value); void setVectorRegister(int num, v128 value);
const char *getRegisterName(int num); static const char *getRegisterName(int num);
void jumpto(); void jumpto();
static int lastDwarfRegNum() { return _LIBUNWIND_HIGHEST_DWARF_REGISTER_X86; } static int lastDwarfRegNum() { return _LIBUNWIND_HIGHEST_DWARF_REGISTER_X86; }
uint32_t getSP() const { return _registers.__esp; } uint32_t getSP() const { return _registers.__esp; }
void setSP(uint32_t value) { _registers.__esp = value; } void setSP(uint32_t value) { _registers.__esp = value; }
uint32_t getIP() const { return _registers.__eip; } uint32_t getIP() const { return _registers.__eip; }
void setIP(uint32_t value) { _registers.__eip = value; } void setIP(uint32_t value) { _registers.__eip = value; }
uint32_t getEBP() const { return _registers.__ebp; } uint32_t getEBP() const { return _registers.__ebp; }
▲ Show 20 Lines • Show All 189 Lines • ▼ Show 20 Linespublic:
uint64_t getRegister(int num) const; uint64_t getRegister(int num) const;
void setRegister(int num, uint64_t value); void setRegister(int num, uint64_t value);
bool validFloatRegister(int) const { return false; } bool validFloatRegister(int) const { return false; }
double getFloatRegister(int num) const; double getFloatRegister(int num) const;
void setFloatRegister(int num, double value); void setFloatRegister(int num, double value);
bool validVectorRegister(int) const; bool validVectorRegister(int) const;
v128 getVectorRegister(int num) const; v128 getVectorRegister(int num) const;
void setVectorRegister(int num, v128 value); void setVectorRegister(int num, v128 value);
const char *getRegisterName(int num); static const char *getRegisterName(int num);
void jumpto(); void jumpto();
static int lastDwarfRegNum() { return _LIBUNWIND_HIGHEST_DWARF_REGISTER_X86_64; } static int lastDwarfRegNum() { return _LIBUNWIND_HIGHEST_DWARF_REGISTER_X86_64; }
uint64_t getSP() const { return _registers.__rsp; } uint64_t getSP() const { return _registers.__rsp; }
void setSP(uint64_t value) { _registers.__rsp = value; } void setSP(uint64_t value) { _registers.__rsp = value; }
uint64_t getIP() const { return _registers.__rip; } uint64_t getIP() const { return _registers.__rip; }
void setIP(uint64_t value) { _registers.__rip = value; } void setIP(uint64_t value) { _registers.__rip = value; }
uint64_t getRBP() const { return _registers.__rbp; } uint64_t getRBP() const { return _registers.__rbp; }
▲ Show 20 Lines • Show All 296 Lines • ▼ Show 20 Linespublic:
uint32_t getRegister(int num) const; uint32_t getRegister(int num) const;
void setRegister(int num, uint32_t value); void setRegister(int num, uint32_t value);
bool validFloatRegister(int num) const; bool validFloatRegister(int num) const;
double getFloatRegister(int num) const; double getFloatRegister(int num) const;
void setFloatRegister(int num, double value); void setFloatRegister(int num, double value);
bool validVectorRegister(int num) const; bool validVectorRegister(int num) const;
v128 getVectorRegister(int num) const; v128 getVectorRegister(int num) const;
void setVectorRegister(int num, v128 value); void setVectorRegister(int num, v128 value);
const char *getRegisterName(int num); static const char *getRegisterName(int num);
void jumpto(); void jumpto();
static int lastDwarfRegNum() { return _LIBUNWIND_HIGHEST_DWARF_REGISTER_PPC; } static int lastDwarfRegNum() { return _LIBUNWIND_HIGHEST_DWARF_REGISTER_PPC; }
uint64_t getSP() const { return _registers.__r1; } uint64_t getSP() const { return _registers.__r1; }
void setSP(uint32_t value) { _registers.__r1 = value; } void setSP(uint32_t value) { _registers.__r1 = value; }
uint64_t getIP() const { return _registers.__srr0; } uint64_t getIP() const { return _registers.__srr0; }
void setIP(uint32_t value) { _registers.__srr0 = value; } void setIP(uint32_t value) { _registers.__srr0 = value; }
▲ Show 20 Lines • Show All 548 Lines • ▼ Show 20 Linespublic:
uint64_t getRegister(int num) const; uint64_t getRegister(int num) const;
void setRegister(int num, uint64_t value); void setRegister(int num, uint64_t value);
bool validFloatRegister(int num) const; bool validFloatRegister(int num) const;
double getFloatRegister(int num) const; double getFloatRegister(int num) const;
void setFloatRegister(int num, double value); void setFloatRegister(int num, double value);
bool validVectorRegister(int num) const; bool validVectorRegister(int num) const;
v128 getVectorRegister(int num) const; v128 getVectorRegister(int num) const;
void setVectorRegister(int num, v128 value); void setVectorRegister(int num, v128 value);
const char *getRegisterName(int num); static const char *getRegisterName(int num);
void jumpto(); void jumpto();
static int lastDwarfRegNum() { return _LIBUNWIND_HIGHEST_DWARF_REGISTER_PPC64; } static int lastDwarfRegNum() { return _LIBUNWIND_HIGHEST_DWARF_REGISTER_PPC64; }
uint64_t getSP() const { return _registers.__r1; } uint64_t getSP() const { return _registers.__r1; }
void setSP(uint64_t value) { _registers.__r1 = value; } void setSP(uint64_t value) { _registers.__r1 = value; }
uint64_t getIP() const { return _registers.__srr0; } uint64_t getIP() const { return _registers.__srr0; }
void setIP(uint64_t value) { _registers.__srr0 = value; } void setIP(uint64_t value) { _registers.__srr0 = value; }
▲ Show 20 Lines • Show All 625 Lines • ▼ Show 20 Linespublic:
uint64_t getRegister(int num) const; uint64_t getRegister(int num) const;
void setRegister(int num, uint64_t value); void setRegister(int num, uint64_t value);
bool validFloatRegister(int num) const; bool validFloatRegister(int num) const;
double getFloatRegister(int num) const; double getFloatRegister(int num) const;
void setFloatRegister(int num, double value); void setFloatRegister(int num, double value);
bool validVectorRegister(int num) const; bool validVectorRegister(int num) const;
v128 getVectorRegister(int num) const; v128 getVectorRegister(int num) const;
void setVectorRegister(int num, v128 value); void setVectorRegister(int num, v128 value);
const char *getRegisterName(int num); static const char *getRegisterName(int num);
void jumpto(); void jumpto();
static int lastDwarfRegNum() { return _LIBUNWIND_HIGHEST_DWARF_REGISTER_ARM64; } static int lastDwarfRegNum() { return _LIBUNWIND_HIGHEST_DWARF_REGISTER_ARM64; }
uint64_t getSP() const { return _registers.__sp; } uint64_t getSP() const { return _registers.__sp; }
void setSP(uint64_t value) { _registers.__sp = value; } void setSP(uint64_t value) { _registers.__sp = value; }
uint64_t getIP() const { return _registers.__pc; } uint64_t getIP() const { return _registers.__pc; }
void setIP(uint64_t value) { _registers.__pc = value; } void setIP(uint64_t value) { _registers.__pc = value; }
uint64_t getFP() const { return _registers.__fp; } uint64_t getFP() const { return _registers.__fp; }
▲ Show 20 Lines • Show All 253 Lines • ▼ Show 20 Linespublic:
uint32_t getRegister(int num) const; uint32_t getRegister(int num) const;
void setRegister(int num, uint32_t value); void setRegister(int num, uint32_t value);
bool validFloatRegister(int num) const; bool validFloatRegister(int num) const;
unw_fpreg_t getFloatRegister(int num); unw_fpreg_t getFloatRegister(int num);
void setFloatRegister(int num, unw_fpreg_t value); void setFloatRegister(int num, unw_fpreg_t value);
bool validVectorRegister(int num) const; bool validVectorRegister(int num) const;
v128 getVectorRegister(int num) const; v128 getVectorRegister(int num) const;
void setVectorRegister(int num, v128 value); void setVectorRegister(int num, v128 value);
const char *getRegisterName(int num); static const char *getRegisterName(int num);
void jumpto() { void jumpto() {
restoreSavedFloatRegisters(); restoreSavedFloatRegisters();
restoreCoreAndJumpTo(); restoreCoreAndJumpTo();
} }
static int lastDwarfRegNum() { return _LIBUNWIND_HIGHEST_DWARF_REGISTER_ARM; } static int lastDwarfRegNum() { return _LIBUNWIND_HIGHEST_DWARF_REGISTER_ARM; }
uint32_t getSP() const { return _registers.__sp; } uint32_t getSP() const { return _registers.__sp; }
void setSP(uint32_t value) { _registers.__sp = value; } void setSP(uint32_t value) { _registers.__sp = value; }
▲ Show 20 Lines • Show All 463 Lines • ▼ Show 20 Linespublic:
uint32_t getRegister(int num) const; uint32_t getRegister(int num) const;
void setRegister(int num, uint32_t value); void setRegister(int num, uint32_t value);
bool validFloatRegister(int num) const; bool validFloatRegister(int num) const;
double getFloatRegister(int num) const; double getFloatRegister(int num) const;
void setFloatRegister(int num, double value); void setFloatRegister(int num, double value);
bool validVectorRegister(int num) const; bool validVectorRegister(int num) const;
v128 getVectorRegister(int num) const; v128 getVectorRegister(int num) const;
void setVectorRegister(int num, v128 value); void setVectorRegister(int num, v128 value);
const char *getRegisterName(int num); static const char *getRegisterName(int num);
void jumpto(); void jumpto();
static int lastDwarfRegNum() { return _LIBUNWIND_HIGHEST_DWARF_REGISTER_OR1K; } static int lastDwarfRegNum() { return _LIBUNWIND_HIGHEST_DWARF_REGISTER_OR1K; }
uint64_t getSP() const { return _registers.__r[1]; } uint64_t getSP() const { return _registers.__r[1]; }
void setSP(uint32_t value) { _registers.__r[1] = value; } void setSP(uint32_t value) { _registers.__r[1] = value; }
uint64_t getIP() const { return _registers.__pc; } uint64_t getIP() const { return _registers.__pc; }
void setIP(uint32_t value) { _registers.__pc = value; } void setIP(uint32_t value) { _registers.__pc = value; }
▲ Show 20 Lines • Show All 179 Lines • ▼ Show 20 Linespublic:
uint32_t getRegister(int num) const; uint32_t getRegister(int num) const;
void setRegister(int num, uint32_t value); void setRegister(int num, uint32_t value);
bool validFloatRegister(int num) const; bool validFloatRegister(int num) const;
double getFloatRegister(int num) const; double getFloatRegister(int num) const;
void setFloatRegister(int num, double value); void setFloatRegister(int num, double value);
bool validVectorRegister(int num) const; bool validVectorRegister(int num) const;
v128 getVectorRegister(int num) const; v128 getVectorRegister(int num) const;
void setVectorRegister(int num, v128 value); void setVectorRegister(int num, v128 value);
const char *getRegisterName(int num); static const char *getRegisterName(int num);
void jumpto(); void jumpto();
static int lastDwarfRegNum() { return _LIBUNWIND_HIGHEST_DWARF_REGISTER_MIPS; } static int lastDwarfRegNum() { return _LIBUNWIND_HIGHEST_DWARF_REGISTER_MIPS; }
uint32_t getSP() const { return _registers.__r[29]; } uint32_t getSP() const { return _registers.__r[29]; }
void setSP(uint32_t value) { _registers.__r[29] = value; } void setSP(uint32_t value) { _registers.__r[29] = value; }
uint32_t getIP() const { return _registers.__pc; } uint32_t getIP() const { return _registers.__pc; }
void setIP(uint32_t value) { _registers.__pc = value; } void setIP(uint32_t value) { _registers.__pc = value; }
▲ Show 20 Lines • Show All 304 Lines • ▼ Show 20 Linespublic:
uint64_t getRegister(int num) const; uint64_t getRegister(int num) const;
void setRegister(int num, uint64_t value); void setRegister(int num, uint64_t value);
bool validFloatRegister(int num) const; bool validFloatRegister(int num) const;
double getFloatRegister(int num) const; double getFloatRegister(int num) const;
void setFloatRegister(int num, double value); void setFloatRegister(int num, double value);
bool validVectorRegister(int num) const; bool validVectorRegister(int num) const;
v128 getVectorRegister(int num) const; v128 getVectorRegister(int num) const;
void setVectorRegister(int num, v128 value); void setVectorRegister(int num, v128 value);
const char *getRegisterName(int num); static const char *getRegisterName(int num);
void jumpto(); void jumpto();
static int lastDwarfRegNum() { return _LIBUNWIND_HIGHEST_DWARF_REGISTER_MIPS; } static int lastDwarfRegNum() { return _LIBUNWIND_HIGHEST_DWARF_REGISTER_MIPS; }
uint64_t getSP() const { return _registers.__r[29]; } uint64_t getSP() const { return _registers.__r[29]; }
void setSP(uint64_t value) { _registers.__r[29] = value; } void setSP(uint64_t value) { _registers.__r[29] = value; }
uint64_t getIP() const { return _registers.__pc; } uint64_t getIP() const { return _registers.__pc; }
void setIP(uint64_t value) { _registers.__pc = value; } void setIP(uint64_t value) { _registers.__pc = value; }
▲ Show 20 Lines • Show All 265 Lines • Show Last 20 Lines

libunwind/trunk/src/UnwindCursor.hpp

Show First 20 Lines • Show All 798 Lines • ▼ Show 20 Lines
} }
#ifdef __arm__ #ifdef __arm__
template <typename A, typename R> void UnwindCursor<A, R>::saveVFPAsX() {} template <typename A, typename R> void UnwindCursor<A, R>::saveVFPAsX() {}
#endif #endif
template <typename A, typename R> template <typename A, typename R>
const char *UnwindCursor<A, R>::getRegisterName(int regNum) { const char *UnwindCursor<A, R>::getRegisterName(int regNum) {
switch (regNum) { return R::getRegisterName(regNum);
#if defined(_LIBUNWIND_TARGET_X86_64)
case UNW_REG_IP: return "rip";
case UNW_X86_64_RAX: return "rax";
case UNW_X86_64_RDX: return "rdx";
case UNW_X86_64_RCX: return "rcx";
case UNW_X86_64_RBX: return "rbx";
case UNW_REG_SP:
case UNW_X86_64_RSP: return "rsp";
case UNW_X86_64_RBP: return "rbp";
case UNW_X86_64_RSI: return "rsi";
case UNW_X86_64_RDI: return "rdi";
case UNW_X86_64_R8: return "r8";
case UNW_X86_64_R9: return "r9";
case UNW_X86_64_R10: return "r10";
case UNW_X86_64_R11: return "r11";
case UNW_X86_64_R12: return "r12";
case UNW_X86_64_R13: return "r13";
case UNW_X86_64_R14: return "r14";
case UNW_X86_64_R15: return "r15";
#elif defined(_LIBUNWIND_TARGET_ARM)
case UNW_ARM_R0: return "r0";
case UNW_ARM_R1: return "r1";
case UNW_ARM_R2: return "r2";
case UNW_ARM_R3: return "r3";
case UNW_ARM_R4: return "r4";
case UNW_ARM_R5: return "r5";
case UNW_ARM_R6: return "r6";
case UNW_ARM_R7: return "r7";
case UNW_ARM_R8: return "r8";
case UNW_ARM_R9: return "r9";
case UNW_ARM_R10: return "r10";
case UNW_ARM_R11: return "r11";
case UNW_ARM_R12: return "r12";
case UNW_REG_SP:
case UNW_ARM_SP: return "sp";
case UNW_ARM_LR: return "lr";
case UNW_REG_IP:
case UNW_ARM_IP: return "pc";
case UNW_ARM_S0: return "s0";
case UNW_ARM_S1: return "s1";
case UNW_ARM_S2: return "s2";
case UNW_ARM_S3: return "s3";
case UNW_ARM_S4: return "s4";
case UNW_ARM_S5: return "s5";
case UNW_ARM_S6: return "s6";
case UNW_ARM_S7: return "s7";
case UNW_ARM_S8: return "s8";
case UNW_ARM_S9: return "s9";
case UNW_ARM_S10: return "s10";
case UNW_ARM_S11: return "s11";
case UNW_ARM_S12: return "s12";
case UNW_ARM_S13: return "s13";
case UNW_ARM_S14: return "s14";
case UNW_ARM_S15: return "s15";
case UNW_ARM_S16: return "s16";
case UNW_ARM_S17: return "s17";
case UNW_ARM_S18: return "s18";
case UNW_ARM_S19: return "s19";
case UNW_ARM_S20: return "s20";
case UNW_ARM_S21: return "s21";
case UNW_ARM_S22: return "s22";
case UNW_ARM_S23: return "s23";
case UNW_ARM_S24: return "s24";
case UNW_ARM_S25: return "s25";
case UNW_ARM_S26: return "s26";
case UNW_ARM_S27: return "s27";
case UNW_ARM_S28: return "s28";
case UNW_ARM_S29: return "s29";
case UNW_ARM_S30: return "s30";
case UNW_ARM_S31: return "s31";
case UNW_ARM_D0: return "d0";
case UNW_ARM_D1: return "d1";
case UNW_ARM_D2: return "d2";
case UNW_ARM_D3: return "d3";
case UNW_ARM_D4: return "d4";
case UNW_ARM_D5: return "d5";
case UNW_ARM_D6: return "d6";
case UNW_ARM_D7: return "d7";
case UNW_ARM_D8: return "d8";
case UNW_ARM_D9: return "d9";
case UNW_ARM_D10: return "d10";
case UNW_ARM_D11: return "d11";
case UNW_ARM_D12: return "d12";
case UNW_ARM_D13: return "d13";
case UNW_ARM_D14: return "d14";
case UNW_ARM_D15: return "d15";
case UNW_ARM_D16: return "d16";
case UNW_ARM_D17: return "d17";
case UNW_ARM_D18: return "d18";
case UNW_ARM_D19: return "d19";
case UNW_ARM_D20: return "d20";
case UNW_ARM_D21: return "d21";
case UNW_ARM_D22: return "d22";
case UNW_ARM_D23: return "d23";
case UNW_ARM_D24: return "d24";
case UNW_ARM_D25: return "d25";
case UNW_ARM_D26: return "d26";
case UNW_ARM_D27: return "d27";
case UNW_ARM_D28: return "d28";
case UNW_ARM_D29: return "d29";
case UNW_ARM_D30: return "d30";
case UNW_ARM_D31: return "d31";
#endif
default:
_LIBUNWIND_ABORT("unsupported register");
}
} }
template <typename A, typename R> bool UnwindCursor<A, R>::isSignalFrame() { template <typename A, typename R> bool UnwindCursor<A, R>::isSignalFrame() {
return false; return false;
} }
#else // !defined(_LIBUNWIND_SUPPORT_SEH_UNWIND) || !defined(_WIN32) #else // !defined(_LIBUNWIND_SUPPORT_SEH_UNWIND) || !defined(_WIN32)
▲ Show 20 Lines • Show All 1,093 Lines • Show Last 20 Lines