This patch updates the implementation of the ompt_frame_t, ompt_wait_id_t and ompt_state_t.
The final version of the OpenMP 5.0 spec added the "t" for these types.
Furthermore the structure for ompt_frame_t changed and allows to specify that the reenter frame belongs to the runtime.
Details
Details
Diff Detail
Diff Detail
Event Timeline
| runtime/src/include/50/ompt.h.var | ||
|---|---|---|
| 56 | I think it's better to change this macro name (to FOREACH_OMPT_STATE) as well. | |
| 182 | Can we #define this variable? | |
| runtime/src/kmp_csupport.cpp | ||
| 510 | I think initializing exit_frame with ompt_data_none is safer. | |
| runtime/src/kmp_gsupport.cpp | ||
| 1087 | Can you align the backslashes in the patch? | |
Comment Actions
Implemented most changes requested by Hansang
| runtime/src/include/50/ompt.h.var | ||
|---|---|---|
| 182 | Currently this change is implemented in https://reviews.llvm.org/D55579 | |
I think it's better to change this macro name (to FOREACH_OMPT_STATE) as well.