Use the standard Duration factory matcher

[hwright]

Summary

A new check came in over the weekend; it should use our existing infrastructure for matching absl::Duration factories.

[JonasToth]

LGTM

[JonasToth]

Please remember to upload your patches with full context (i can highly recommend using arc, see https://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch and https://llvm.org/docs/Phabricator.html for the relevant command).

[lebedev.ri]

In D55541#1326867, @JonasToth wrote:

Please remember to upload your patches with full context (i can highly recommend using arc, see https://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch and https://llvm.org/docs/Phabricator.html for the relevant command).

And to add to that, please do set the correct "Repo" field, correct tag if appropriate (clang-tools-extra), and subscribe the appropriate -commits list (in this case, cfe-commits.)

[JonasToth]

In D55541#1326868, @lebedev.ri wrote:

In D55541#1326867, @JonasToth wrote:

Please remember to upload your patches with full context (i can highly recommend using arc, see https://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch and https://llvm.org/docs/Phabricator.html for the relevant command).

And to add to that, please do set the correct "Repo" field, correct tag if appropriate (clang-tools-extra), and subscribe the appropriate -commits list (in this case, cfe-commits.)

Wups, overlooked that too, but your right.

clang-tools-extra/trunk/clang-tidy/abseil/UpgradeDurationConversionsCheck.cpp

 //===--- UpgradeDurationConversionsCheck.cpp - clang-tidy -----------------===//
 //
 //                     The LLVM Compiler Infrastructure
 //
 // This file is distributed under the University of Illinois Open Source
 // License. See LICENSE.TXT for details.
 //
 //===----------------------------------------------------------------------===//
 
 #include "UpgradeDurationConversionsCheck.h"
+#include "DurationRewriter.h"
 #include "clang/AST/ASTContext.h"
 #include "clang/ASTMatchers/ASTMatchFinder.h"
 
 using namespace clang::ast_matchers;
 
 namespace clang {
 namespace tidy {
 namespace abseil {
void UpgradeDurationConversionsCheck::registerMatchers(MatchFinder *Finder) {
   //   `absl::Minutes(x)`
   //   `absl::Hours(x)`
   // where `x` is not of a built-in type.
   Finder->addMatcher(
       implicitCastExpr(
           anyOf(hasCastKind(CK_UserDefinedConversion),
                 has(implicitCastExpr(hasCastKind(CK_UserDefinedConversion)))),
           hasParent(callExpr(
-              callee(functionDecl(
-                  hasAnyName("::absl::Nanoseconds", "::absl::Microseconds",
-                             "::absl::Milliseconds", "::absl::Seconds",
-                             "::absl::Minutes", "::absl::Hours"),
+              callee(functionDecl(DurationFactoryFunction(),
                   unless(hasParent(functionTemplateDecl())))),
               hasArgument(0, expr().bind("arg"))))),
       this);
 }
 
 void UpgradeDurationConversionsCheck::check(
     const MatchFinder::MatchResult &Result) {
   const llvm::StringRef Message =