Page MenuHomePhabricator

hwright (Hyrum Wright)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 16 2018, 1:46 PM (22 w, 3 d)

Recent Activity

Thu, Mar 14

hwright committed rG4199a73ceee7: [clang-tidy] Add additional patterns to the abseil-duration-unnecessary… (authored by hwright).
[clang-tidy] Add additional patterns to the abseil-duration-unnecessary…
Thu, Mar 14, 6:40 AM
hwright committed rL356141: [clang-tidy] Add additional patterns to the abseil-duration-unnecessary….
[clang-tidy] Add additional patterns to the abseil-duration-unnecessary…
Thu, Mar 14, 6:40 AM
hwright committed rCTE356141: [clang-tidy] Add additional patterns to the abseil-duration-unnecessary….
[clang-tidy] Add additional patterns to the abseil-duration-unnecessary…
Thu, Mar 14, 6:40 AM
hwright closed D59183: [clang-tidy] Expand cases covered by the abseil-duration-unnecessary-conversion check.
Thu, Mar 14, 6:40 AM · Restricted Project, Restricted Project

Wed, Mar 13

hwright added inline comments to D59183: [clang-tidy] Expand cases covered by the abseil-duration-unnecessary-conversion check.
Wed, Mar 13, 11:09 AM · Restricted Project, Restricted Project
hwright updated the diff for D59183: [clang-tidy] Expand cases covered by the abseil-duration-unnecessary-conversion check.

Addressed reviewer comments

Wed, Mar 13, 11:09 AM · Restricted Project, Restricted Project

Mon, Mar 11

hwright committed rG1603447b0379: [clang-tidy] Add the abseil-time-compare check (authored by hwright).
[clang-tidy] Add the abseil-time-compare check
Mon, Mar 11, 9:48 AM
hwright committed rL355835: [clang-tidy] Add the abseil-time-compare check.
[clang-tidy] Add the abseil-time-compare check
Mon, Mar 11, 9:48 AM
hwright committed rCTE355835: [clang-tidy] Add the abseil-time-compare check.
[clang-tidy] Add the abseil-time-compare check
Mon, Mar 11, 9:48 AM
hwright closed D58977: [clang-tidy] Add the abseil-time-comparison check.
Mon, Mar 11, 9:47 AM · Restricted Project, Restricted Project
hwright updated the diff for D58977: [clang-tidy] Add the abseil-time-comparison check.
Mon, Mar 11, 6:13 AM · Restricted Project, Restricted Project

Sat, Mar 9

hwright added a project to D59183: [clang-tidy] Expand cases covered by the abseil-duration-unnecessary-conversion check: Restricted Project.
Sat, Mar 9, 6:18 PM · Restricted Project, Restricted Project
hwright created D59183: [clang-tidy] Expand cases covered by the abseil-duration-unnecessary-conversion check.
Sat, Mar 9, 6:18 PM · Restricted Project, Restricted Project

Fri, Mar 8

hwright added inline comments to D58977: [clang-tidy] Add the abseil-time-comparison check.
Fri, Mar 8, 8:15 AM · Restricted Project, Restricted Project
hwright updated the diff for D58977: [clang-tidy] Add the abseil-time-comparison check.
Fri, Mar 8, 8:15 AM · Restricted Project, Restricted Project
hwright committed rG8172a0a5f4a8: [clang-tidy] NFC: Negate the name and semantics of the isNotInMacro function. (authored by hwright).
[clang-tidy] NFC: Negate the name and semantics of the isNotInMacro function.
Fri, Mar 8, 7:39 AM
hwright committed rCTE355702: [clang-tidy] NFC: Negate the name and semantics of the isNotInMacro function..
[clang-tidy] NFC: Negate the name and semantics of the isNotInMacro function.
Fri, Mar 8, 7:39 AM
hwright committed rL355702: [clang-tidy] NFC: Negate the name and semantics of the isNotInMacro function..
[clang-tidy] NFC: Negate the name and semantics of the isNotInMacro function.
Fri, Mar 8, 7:39 AM

Tue, Mar 5

hwright added a reviewer for D58977: [clang-tidy] Add the abseil-time-comparison check: JonasToth.
Tue, Mar 5, 12:06 PM · Restricted Project, Restricted Project
hwright created D58977: [clang-tidy] Add the abseil-time-comparison check.
Tue, Mar 5, 8:35 AM · Restricted Project, Restricted Project

Wed, Feb 27

hwright committed rGc526e02668b3: [clang-tidy] Add the abseil-time-subtraction check (authored by hwright).
[clang-tidy] Add the abseil-time-subtraction check
Wed, Feb 27, 12:09 PM
hwright committed rL355024: [clang-tidy] Add the abseil-time-subtraction check.
[clang-tidy] Add the abseil-time-subtraction check
Wed, Feb 27, 12:08 PM
hwright committed rCTE355024: [clang-tidy] Add the abseil-time-subtraction check.
[clang-tidy] Add the abseil-time-subtraction check
Wed, Feb 27, 12:08 PM
hwright closed D58137: [clang-tidy] Add the abseil-time-subtraction check.
Wed, Feb 27, 12:08 PM · Restricted Project, Restricted Project

Tue, Feb 26

hwright added inline comments to D58137: [clang-tidy] Add the abseil-time-subtraction check.
Tue, Feb 26, 7:16 AM · Restricted Project, Restricted Project
hwright updated the diff for D58137: [clang-tidy] Add the abseil-time-subtraction check.
Tue, Feb 26, 7:16 AM · Restricted Project, Restricted Project

Mon, Feb 25

hwright added inline comments to D58137: [clang-tidy] Add the abseil-time-subtraction check.
Mon, Feb 25, 6:15 PM · Restricted Project, Restricted Project
hwright updated the diff for D58137: [clang-tidy] Add the abseil-time-subtraction check.
Mon, Feb 25, 6:15 PM · Restricted Project, Restricted Project

Fri, Feb 22

hwright added inline comments to D58137: [clang-tidy] Add the abseil-time-subtraction check.
Fri, Feb 22, 12:24 PM · Restricted Project, Restricted Project
hwright updated the diff for D58137: [clang-tidy] Add the abseil-time-subtraction check.
Fri, Feb 22, 12:24 PM · Restricted Project, Restricted Project

Feb 12 2019

hwright updated the diff for D58137: [clang-tidy] Add the abseil-time-subtraction check.
Feb 12 2019, 5:21 PM · Restricted Project, Restricted Project
hwright created D58137: [clang-tidy] Add the abseil-time-subtraction check.
Feb 12 2019, 10:27 AM · Restricted Project, Restricted Project

Feb 4 2019

hwright committed rG1c250bf2968b: [clang-tidy] Add the abseil-duration-unnecessary-conversion check (authored by hwright).
[clang-tidy] Add the abseil-duration-unnecessary-conversion check
Feb 4 2019, 11:29 AM
hwright committed rL353079: [clang-tidy] Add the abseil-duration-unnecessary-conversion check.
[clang-tidy] Add the abseil-duration-unnecessary-conversion check
Feb 4 2019, 11:28 AM
hwright committed rCTE353079: [clang-tidy] Add the abseil-duration-unnecessary-conversion check.
[clang-tidy] Add the abseil-duration-unnecessary-conversion check
Feb 4 2019, 11:28 AM
hwright closed D57353: [clang-tidy] Add the abseil-duration-unnecessary-conversion check.
Feb 4 2019, 11:28 AM · Restricted Project, Restricted Project
hwright added a comment to D57353: [clang-tidy] Add the abseil-duration-unnecessary-conversion check.

@hokein Thanks for the suggestion on the name, I was looking for something a little less confusing.

Feb 4 2019, 8:03 AM · Restricted Project, Restricted Project
hwright updated the diff for D57353: [clang-tidy] Add the abseil-duration-unnecessary-conversion check.

Renamed to abseil-duration-unnecessary-conversion

Feb 4 2019, 8:03 AM · Restricted Project, Restricted Project

Feb 2 2019

hwright committed rCTE352964: [clang-tidy] Rename time lookup functions; NFC.
[clang-tidy] Rename time lookup functions; NFC
Feb 2 2019, 11:57 AM
hwright committed rL352964: [clang-tidy] Rename time lookup functions; NFC.
[clang-tidy] Rename time lookup functions; NFC
Feb 2 2019, 11:57 AM

Feb 1 2019

hwright added a reviewer for D57353: [clang-tidy] Add the abseil-duration-unnecessary-conversion check: ioeric.
Feb 1 2019, 8:08 AM · Restricted Project, Restricted Project
hwright updated subscribers of D57353: [clang-tidy] Add the abseil-duration-unnecessary-conversion check.
Feb 1 2019, 8:08 AM · Restricted Project, Restricted Project

Jan 30 2019

hwright added inline comments to D57353: [clang-tidy] Add the abseil-duration-unnecessary-conversion check.
Jan 30 2019, 12:13 PM · Restricted Project, Restricted Project

Jan 29 2019

hwright added inline comments to D57353: [clang-tidy] Add the abseil-duration-unnecessary-conversion check.
Jan 29 2019, 11:49 AM · Restricted Project, Restricted Project
hwright updated the diff for D57353: [clang-tidy] Add the abseil-duration-unnecessary-conversion check.
Jan 29 2019, 11:48 AM · Restricted Project, Restricted Project
hwright added inline comments to D57353: [clang-tidy] Add the abseil-duration-unnecessary-conversion check.
Jan 29 2019, 11:38 AM · Restricted Project, Restricted Project
hwright updated the diff for D57353: [clang-tidy] Add the abseil-duration-unnecessary-conversion check.

Address reviewer comments.

Jan 29 2019, 11:38 AM · Restricted Project, Restricted Project

Jan 28 2019

hwright created D57353: [clang-tidy] Add the abseil-duration-unnecessary-conversion check.
Jan 28 2019, 12:51 PM · Restricted Project, Restricted Project
hwright committed rCTE352362: [clang-tidy] Add the abseil-duration-addition check.
[clang-tidy] Add the abseil-duration-addition check
Jan 28 2019, 6:05 AM
hwright committed rL352362: [clang-tidy] Add the abseil-duration-addition check.
[clang-tidy] Add the abseil-duration-addition check
Jan 28 2019, 6:03 AM
hwright closed D57185: [clang-tidy] Add the abseil-duration-addition check.
Jan 28 2019, 6:03 AM · Restricted Project

Jan 25 2019

hwright updated the diff for D57185: [clang-tidy] Add the abseil-duration-addition check.

Add another test

Jan 25 2019, 11:17 AM · Restricted Project
hwright added inline comments to D57185: [clang-tidy] Add the abseil-duration-addition check.
Jan 25 2019, 7:45 AM · Restricted Project
hwright added inline comments to D57185: [clang-tidy] Add the abseil-duration-addition check.
Jan 25 2019, 7:20 AM · Restricted Project
hwright updated the diff for D57185: [clang-tidy] Add the abseil-duration-addition check.
Jan 25 2019, 7:19 AM · Restricted Project
hwright updated the diff for D57185: [clang-tidy] Add the abseil-duration-addition check.

Sort release notes

Jan 25 2019, 6:24 AM · Restricted Project

Jan 24 2019

hwright created D57185: [clang-tidy] Add the abseil-duration-addition check.
Jan 24 2019, 1:33 PM · Restricted Project
hwright committed rL352088: [clang-tidy] Rename the absl duration helper functions; NFC.
[clang-tidy] Rename the absl duration helper functions; NFC
Jan 24 2019, 11:24 AM
hwright committed rCTE352088: [clang-tidy] Rename the absl duration helper functions; NFC.
[clang-tidy] Rename the absl duration helper functions; NFC
Jan 24 2019, 11:23 AM

Jan 17 2019

hwright committed rCTE351473: [clang-tidy] Add abseil-duration-conversion-cast check.
[clang-tidy] Add abseil-duration-conversion-cast check
Jan 17 2019, 12:43 PM
hwright committed rL351473: [clang-tidy] Add abseil-duration-conversion-cast check.
[clang-tidy] Add abseil-duration-conversion-cast check
Jan 17 2019, 12:43 PM
hwright closed D56532: [clang-tidy] Add the abseil-duration-conversion-cast check.
Jan 17 2019, 12:43 PM · Restricted Project

Jan 16 2019

hwright updated the diff for D56532: [clang-tidy] Add the abseil-duration-conversion-cast check.

Address reviewer comments

Jan 16 2019, 7:27 AM · Restricted Project
hwright added inline comments to D56532: [clang-tidy] Add the abseil-duration-conversion-cast check.
Jan 16 2019, 7:27 AM · Restricted Project
hwright committed rL351348: [clang-tidy] Move the macro helper function to a common location; NFC.
[clang-tidy] Move the macro helper function to a common location; NFC
Jan 16 2019, 6:53 AM
hwright committed rCTE351348: [clang-tidy] Move the macro helper function to a common location; NFC.
[clang-tidy] Move the macro helper function to a common location; NFC
Jan 16 2019, 6:53 AM

Jan 14 2019

hwright added a comment to D56532: [clang-tidy] Add the abseil-duration-conversion-cast check.

Ping.

Jan 14 2019, 2:49 AM · Restricted Project

Jan 10 2019

hwright updated the diff for D56532: [clang-tidy] Add the abseil-duration-conversion-cast check.

Run clang-format

Jan 10 2019, 7:01 PM · Restricted Project
hwright added inline comments to D56532: [clang-tidy] Add the abseil-duration-conversion-cast check.
Jan 10 2019, 12:09 PM · Restricted Project
hwright updated the diff for D56532: [clang-tidy] Add the abseil-duration-conversion-cast check.

Update documentation line wrapping.

Jan 10 2019, 12:09 PM · Restricted Project
hwright added a reviewer for D56532: [clang-tidy] Add the abseil-duration-conversion-cast check: JonasToth.
Jan 10 2019, 8:46 AM · Restricted Project

Jan 9 2019

hwright created D56532: [clang-tidy] Add the abseil-duration-conversion-cast check.
Jan 9 2019, 7:13 PM · Restricted Project

Jan 7 2019

hwright committed rCTE350526: [clang-tidy] Use the public hasInit matcher, rather than defining our own, NFC.
[clang-tidy] Use the public hasInit matcher, rather than defining our own, NFC
Jan 7 2019, 6:40 AM
hwright committed rL350526: [clang-tidy] Use the public hasInit matcher, rather than defining our own, NFC.
[clang-tidy] Use the public hasInit matcher, rather than defining our own, NFC
Jan 7 2019, 6:40 AM
hwright committed rC350523: [clang] Add AST matcher for initializer list members.
[clang] Add AST matcher for initializer list members
Jan 7 2019, 6:19 AM
hwright committed rL350523: [clang] Add AST matcher for initializer list members.
[clang] Add AST matcher for initializer list members
Jan 7 2019, 6:19 AM
hwright closed D56090: Add a matcher for members of an initializer list expression.
Jan 7 2019, 6:18 AM · Restricted Project

Jan 4 2019

hwright added inline comments to D56090: Add a matcher for members of an initializer list expression.
Jan 4 2019, 9:01 AM · Restricted Project
hwright updated the diff for D56090: Add a matcher for members of an initializer list expression.

Removed IgnoreParenImpCasts call.

Jan 4 2019, 9:00 AM · Restricted Project

Jan 3 2019

hwright added inline comments to D56090: Add a matcher for members of an initializer list expression.
Jan 3 2019, 9:34 AM · Restricted Project
hwright updated the diff for D56090: Add a matcher for members of an initializer list expression.

Added tests, update docs.

Jan 3 2019, 9:34 AM · Restricted Project

Dec 28 2018

hwright committed rCTE350133: [clang-tidy] Export the abseil duration inverse lookup function, NFC.
[clang-tidy] Export the abseil duration inverse lookup function, NFC
Dec 28 2018, 11:24 AM
hwright committed rL350133: [clang-tidy] Export the abseil duration inverse lookup function, NFC.
[clang-tidy] Export the abseil duration inverse lookup function, NFC
Dec 28 2018, 11:07 AM

Dec 26 2018

hwright added a comment to D56090: Add a matcher for members of an initializer list expression.

@lebedev.ri Where do the appropriate tests live? (I couldn't find an obvious subdirectory in test/)
Where are the instructions for regenerating the documentation?

Dec 26 2018, 2:05 PM · Restricted Project
hwright created D56090: Add a matcher for members of an initializer list expression.
Dec 26 2018, 1:58 PM · Restricted Project

Dec 21 2018

hwright committed rCTE349953: [clang-tidy] Be more liberal about literal zeroes in abseil checks.
[clang-tidy] Be more liberal about literal zeroes in abseil checks
Dec 21 2018, 1:10 PM
hwright committed rL349953: [clang-tidy] Be more liberal about literal zeroes in abseil checks.
[clang-tidy] Be more liberal about literal zeroes in abseil checks
Dec 21 2018, 1:10 PM
hwright closed D56012: [clang-tidy] Be more liberal about literal zeroes in abseil checks.
Dec 21 2018, 1:10 PM · Restricted Project
hwright added a comment to D56012: [clang-tidy] Be more liberal about literal zeroes in abseil checks.

btw, I think hasInit should probably be moved into the core set of matchers at some point.

Dec 21 2018, 12:59 PM · Restricted Project
hwright updated the diff for D56012: [clang-tidy] Be more liberal about literal zeroes in abseil checks.

Add documentation, adjust test.

Dec 21 2018, 12:58 PM · Restricted Project
hwright created D56012: [clang-tidy] Be more liberal about literal zeroes in abseil checks.
Dec 21 2018, 10:12 AM · Restricted Project

Dec 19 2018

hwright committed rL349636: [clang-tidy] Diagnose abseil-duration-comparison on macro arguments.
[clang-tidy] Diagnose abseil-duration-comparison on macro arguments
Dec 19 2018, 8:06 AM
hwright committed rCTE349636: [clang-tidy] Diagnose abseil-duration-comparison on macro arguments.
[clang-tidy] Diagnose abseil-duration-comparison on macro arguments
Dec 19 2018, 8:06 AM
hwright closed D55784: [clang-tidy] Update abseil-duration-comparison to handle macro arguments.
Dec 19 2018, 8:06 AM · Restricted Project
hwright added inline comments to D55784: [clang-tidy] Update abseil-duration-comparison to handle macro arguments.
Dec 19 2018, 8:01 AM · Restricted Project

Dec 18 2018

hwright added a comment to D55784: [clang-tidy] Update abseil-duration-comparison to handle macro arguments.

@aaron.ballman I am both grateful and sad that I don't possess the same macro creativity as you do. :)

Dec 18 2018, 10:44 AM · Restricted Project
hwright updated the diff for D55784: [clang-tidy] Update abseil-duration-comparison to handle macro arguments.

Another test.

Dec 18 2018, 10:42 AM · Restricted Project
hwright added inline comments to D55784: [clang-tidy] Update abseil-duration-comparison to handle macro arguments.
Dec 18 2018, 8:03 AM · Restricted Project
hwright updated the diff for D55784: [clang-tidy] Update abseil-duration-comparison to handle macro arguments.

Update tests

Dec 18 2018, 8:03 AM · Restricted Project

Dec 17 2018

hwright added a reviewer for D55784: [clang-tidy] Update abseil-duration-comparison to handle macro arguments: JonasToth.
Dec 17 2018, 12:24 PM · Restricted Project