Page MenuHomePhabricator

hwright (Hyrum Wright)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 16 2018, 1:46 PM (14 w, 1 d)

Recent Activity

Thu, Jan 17

hwright committed rCTE351473: [clang-tidy] Add abseil-duration-conversion-cast check.
[clang-tidy] Add abseil-duration-conversion-cast check
Thu, Jan 17, 12:43 PM
hwright committed rL351473: [clang-tidy] Add abseil-duration-conversion-cast check.
[clang-tidy] Add abseil-duration-conversion-cast check
Thu, Jan 17, 12:43 PM
hwright closed D56532: [clang-tidy] Add the abseil-duration-conversion-cast check.
Thu, Jan 17, 12:43 PM · Restricted Project

Wed, Jan 16

hwright updated the diff for D56532: [clang-tidy] Add the abseil-duration-conversion-cast check.

Address reviewer comments

Wed, Jan 16, 7:27 AM · Restricted Project
hwright added inline comments to D56532: [clang-tidy] Add the abseil-duration-conversion-cast check.
Wed, Jan 16, 7:27 AM · Restricted Project
hwright committed rL351348: [clang-tidy] Move the macro helper function to a common location; NFC.
[clang-tidy] Move the macro helper function to a common location; NFC
Wed, Jan 16, 6:53 AM
hwright committed rCTE351348: [clang-tidy] Move the macro helper function to a common location; NFC.
[clang-tidy] Move the macro helper function to a common location; NFC
Wed, Jan 16, 6:53 AM

Mon, Jan 14

hwright added a comment to D56532: [clang-tidy] Add the abseil-duration-conversion-cast check.

Ping.

Mon, Jan 14, 2:49 AM · Restricted Project

Thu, Jan 10

hwright updated the diff for D56532: [clang-tidy] Add the abseil-duration-conversion-cast check.

Run clang-format

Thu, Jan 10, 7:01 PM · Restricted Project
hwright added inline comments to D56532: [clang-tidy] Add the abseil-duration-conversion-cast check.
Thu, Jan 10, 12:09 PM · Restricted Project
hwright updated the diff for D56532: [clang-tidy] Add the abseil-duration-conversion-cast check.

Update documentation line wrapping.

Thu, Jan 10, 12:09 PM · Restricted Project
hwright added a reviewer for D56532: [clang-tidy] Add the abseil-duration-conversion-cast check: JonasToth.
Thu, Jan 10, 8:46 AM · Restricted Project

Wed, Jan 9

hwright created D56532: [clang-tidy] Add the abseil-duration-conversion-cast check.
Wed, Jan 9, 7:13 PM · Restricted Project

Mon, Jan 7

hwright committed rCTE350526: [clang-tidy] Use the public hasInit matcher, rather than defining our own, NFC.
[clang-tidy] Use the public hasInit matcher, rather than defining our own, NFC
Mon, Jan 7, 6:40 AM
hwright committed rL350526: [clang-tidy] Use the public hasInit matcher, rather than defining our own, NFC.
[clang-tidy] Use the public hasInit matcher, rather than defining our own, NFC
Mon, Jan 7, 6:40 AM
hwright committed rC350523: [clang] Add AST matcher for initializer list members.
[clang] Add AST matcher for initializer list members
Mon, Jan 7, 6:19 AM
hwright committed rL350523: [clang] Add AST matcher for initializer list members.
[clang] Add AST matcher for initializer list members
Mon, Jan 7, 6:19 AM
hwright closed D56090: Add a matcher for members of an initializer list expression.
Mon, Jan 7, 6:18 AM · Restricted Project

Fri, Jan 4

hwright added inline comments to D56090: Add a matcher for members of an initializer list expression.
Fri, Jan 4, 9:01 AM · Restricted Project
hwright updated the diff for D56090: Add a matcher for members of an initializer list expression.

Removed IgnoreParenImpCasts call.

Fri, Jan 4, 9:00 AM · Restricted Project

Thu, Jan 3

hwright added inline comments to D56090: Add a matcher for members of an initializer list expression.
Thu, Jan 3, 9:34 AM · Restricted Project
hwright updated the diff for D56090: Add a matcher for members of an initializer list expression.

Added tests, update docs.

Thu, Jan 3, 9:34 AM · Restricted Project

Fri, Dec 28

hwright committed rCTE350133: [clang-tidy] Export the abseil duration inverse lookup function, NFC.
[clang-tidy] Export the abseil duration inverse lookup function, NFC
Fri, Dec 28, 11:24 AM
hwright committed rL350133: [clang-tidy] Export the abseil duration inverse lookup function, NFC.
[clang-tidy] Export the abseil duration inverse lookup function, NFC
Fri, Dec 28, 11:07 AM

Wed, Dec 26

hwright added a comment to D56090: Add a matcher for members of an initializer list expression.

@lebedev.ri Where do the appropriate tests live? (I couldn't find an obvious subdirectory in test/)
Where are the instructions for regenerating the documentation?

Wed, Dec 26, 2:05 PM · Restricted Project
hwright created D56090: Add a matcher for members of an initializer list expression.
Wed, Dec 26, 1:58 PM · Restricted Project

Dec 21 2018

hwright committed rCTE349953: [clang-tidy] Be more liberal about literal zeroes in abseil checks.
[clang-tidy] Be more liberal about literal zeroes in abseil checks
Dec 21 2018, 1:10 PM
hwright committed rL349953: [clang-tidy] Be more liberal about literal zeroes in abseil checks.
[clang-tidy] Be more liberal about literal zeroes in abseil checks
Dec 21 2018, 1:10 PM
hwright closed D56012: [clang-tidy] Be more liberal about literal zeroes in abseil checks.
Dec 21 2018, 1:10 PM · Restricted Project
hwright added a comment to D56012: [clang-tidy] Be more liberal about literal zeroes in abseil checks.

btw, I think hasInit should probably be moved into the core set of matchers at some point.

Dec 21 2018, 12:59 PM · Restricted Project
hwright updated the diff for D56012: [clang-tidy] Be more liberal about literal zeroes in abseil checks.

Add documentation, adjust test.

Dec 21 2018, 12:58 PM · Restricted Project
hwright created D56012: [clang-tidy] Be more liberal about literal zeroes in abseil checks.
Dec 21 2018, 10:12 AM · Restricted Project

Dec 19 2018

hwright committed rL349636: [clang-tidy] Diagnose abseil-duration-comparison on macro arguments.
[clang-tidy] Diagnose abseil-duration-comparison on macro arguments
Dec 19 2018, 8:06 AM
hwright committed rCTE349636: [clang-tidy] Diagnose abseil-duration-comparison on macro arguments.
[clang-tidy] Diagnose abseil-duration-comparison on macro arguments
Dec 19 2018, 8:06 AM
hwright closed D55784: [clang-tidy] Update abseil-duration-comparison to handle macro arguments.
Dec 19 2018, 8:06 AM · Restricted Project
hwright added inline comments to D55784: [clang-tidy] Update abseil-duration-comparison to handle macro arguments.
Dec 19 2018, 8:01 AM · Restricted Project

Dec 18 2018

hwright added a comment to D55784: [clang-tidy] Update abseil-duration-comparison to handle macro arguments.

@aaron.ballman I am both grateful and sad that I don't possess the same macro creativity as you do. :)

Dec 18 2018, 10:44 AM · Restricted Project
hwright updated the diff for D55784: [clang-tidy] Update abseil-duration-comparison to handle macro arguments.

Another test.

Dec 18 2018, 10:42 AM · Restricted Project
hwright added inline comments to D55784: [clang-tidy] Update abseil-duration-comparison to handle macro arguments.
Dec 18 2018, 8:03 AM · Restricted Project
hwright updated the diff for D55784: [clang-tidy] Update abseil-duration-comparison to handle macro arguments.

Update tests

Dec 18 2018, 8:03 AM · Restricted Project

Dec 17 2018

hwright added a reviewer for D55784: [clang-tidy] Update abseil-duration-comparison to handle macro arguments: JonasToth.
Dec 17 2018, 12:24 PM · Restricted Project
hwright created D55784: [clang-tidy] Update abseil-duration-comparison to handle macro arguments.
Dec 17 2018, 12:24 PM · Restricted Project

Dec 13 2018

hwright committed rCTE349073: [clang-tidy] Add the abseil-duration-subtraction check.
[clang-tidy] Add the abseil-duration-subtraction check
Dec 13 2018, 11:27 AM
hwright committed rL349073: [clang-tidy] Add the abseil-duration-subtraction check.
[clang-tidy] Add the abseil-duration-subtraction check
Dec 13 2018, 11:27 AM
hwright closed D55245: [clang-tidy] Add the abseil-duration-subtraction check.
Dec 13 2018, 11:27 AM · Restricted Project
hwright added a comment to D55245: [clang-tidy] Add the abseil-duration-subtraction check.

Thanks for reviewing, I'll go ahead and commit.

Dec 13 2018, 11:26 AM · Restricted Project
hwright added a comment to D55245: [clang-tidy] Add the abseil-duration-subtraction check.

I've updated the documentation, and the rebased to master.

Dec 13 2018, 5:30 AM · Restricted Project
hwright updated the diff for D55245: [clang-tidy] Add the abseil-duration-subtraction check.

Rebase and update documentation

Dec 13 2018, 5:30 AM · Restricted Project

Dec 12 2018

hwright added inline comments to D55245: [clang-tidy] Add the abseil-duration-subtraction check.
Dec 12 2018, 6:36 PM · Restricted Project

Dec 11 2018

hwright added inline comments to D55245: [clang-tidy] Add the abseil-duration-subtraction check.
Dec 11 2018, 11:28 AM · Restricted Project
hwright updated the diff for D55245: [clang-tidy] Add the abseil-duration-subtraction check.

Rebase

Dec 11 2018, 11:28 AM · Restricted Project

Dec 10 2018

hwright added a reviewer for D55541: Use the standard Duration factory matcher: JonasToth.
Dec 10 2018, 6:39 PM · Restricted Project
hwright created D55541: Use the standard Duration factory matcher.
Dec 10 2018, 6:37 PM · Restricted Project
hwright created D55540: Consolidate test absl::Time implementation.
Dec 10 2018, 6:30 PM · Restricted Project
hwright added inline comments to D55245: [clang-tidy] Add the abseil-duration-subtraction check.
Dec 10 2018, 1:03 PM · Restricted Project
hwright updated the diff for D55245: [clang-tidy] Add the abseil-duration-subtraction check.

Add tests

Dec 10 2018, 1:03 PM · Restricted Project
hwright added inline comments to D55245: [clang-tidy] Add the abseil-duration-subtraction check.
Dec 10 2018, 7:36 AM · Restricted Project
hwright updated the diff for D55245: [clang-tidy] Add the abseil-duration-subtraction check.

Use static_cast instead of a switch for IndexedMap lookup.

Dec 10 2018, 7:36 AM · Restricted Project
hwright added a comment to D55245: [clang-tidy] Add the abseil-duration-subtraction check.

Reminder: I'll need somebody to submit this for me, since I don't have subversion access.

Dec 10 2018, 4:08 AM · Restricted Project

Dec 7 2018

hwright added inline comments to D55245: [clang-tidy] Add the abseil-duration-subtraction check.
Dec 7 2018, 2:39 PM · Restricted Project
hwright updated the diff for D55245: [clang-tidy] Add the abseil-duration-subtraction check.

Use an IndexedMap instead of an std::unordered_map

Dec 7 2018, 2:39 PM · Restricted Project
hwright added inline comments to D55245: [clang-tidy] Add the abseil-duration-subtraction check.
Dec 7 2018, 11:42 AM · Restricted Project
hwright updated the diff for D55245: [clang-tidy] Add the abseil-duration-subtraction check.
Dec 7 2018, 11:42 AM · Restricted Project

Dec 5 2018

hwright added a comment to D55245: [clang-tidy] Add the abseil-duration-subtraction check.

I assume I've got the right reviewers here, but I've also been sending a bunch of stuff your way lately, so if I'm overwhelming review capacity, please let me know.

Dec 5 2018, 12:14 PM · Restricted Project

Dec 4 2018

hwright updated the diff for D55245: [clang-tidy] Add the abseil-duration-subtraction check.

Fix double space.

Dec 4 2018, 7:43 PM · Restricted Project
hwright updated the summary of D55245: [clang-tidy] Add the abseil-duration-subtraction check.
Dec 4 2018, 6:36 AM · Restricted Project

Dec 3 2018

hwright updated the diff for D55245: [clang-tidy] Add the abseil-duration-subtraction check.

Fix docs.

Dec 3 2018, 7:33 PM · Restricted Project
hwright created D55245: [clang-tidy] Add the abseil-duration-subtraction check.
Dec 3 2018, 7:30 PM · Restricted Project

Nov 30 2018

hwright added a comment to D54737: [clang-tidy] Add the abseil-duration-comparison check.

Oh, and thanks for taking the time to review this. :)

Nov 30 2018, 10:17 AM · Restricted Project
hwright added a comment to D54737: [clang-tidy] Add the abseil-duration-comparison check.

@JonasToth reminder that you (or somebody else) will need to commit this for me.

Nov 30 2018, 10:04 AM · Restricted Project
hwright updated the diff for D54737: [clang-tidy] Add the abseil-duration-comparison check.

Add additional test

Nov 30 2018, 10:03 AM · Restricted Project
hwright updated the diff for D54737: [clang-tidy] Add the abseil-duration-comparison check.

Slightly simplify the fixit text

Nov 30 2018, 5:48 AM · Restricted Project

Nov 29 2018

hwright added a comment to D54737: [clang-tidy] Add the abseil-duration-comparison check.

Ping.

Nov 29 2018, 4:53 PM · Restricted Project
hwright added inline comments to D54737: [clang-tidy] Add the abseil-duration-comparison check.
Nov 29 2018, 4:00 AM · Restricted Project

Nov 28 2018

hwright added inline comments to D54737: [clang-tidy] Add the abseil-duration-comparison check.
Nov 28 2018, 1:38 PM · Restricted Project
hwright added inline comments to D54737: [clang-tidy] Add the abseil-duration-comparison check.
Nov 28 2018, 11:40 AM · Restricted Project
hwright updated the diff for D54737: [clang-tidy] Add the abseil-duration-comparison check.
Nov 28 2018, 11:40 AM · Restricted Project
hwright added a comment to D54737: [clang-tidy] Add the abseil-duration-comparison check.

Anything else for me here?

Nov 28 2018, 9:35 AM · Restricted Project

Nov 27 2018

hwright added inline comments to D54737: [clang-tidy] Add the abseil-duration-comparison check.
Nov 27 2018, 10:23 AM · Restricted Project
hwright added inline comments to D54737: [clang-tidy] Add the abseil-duration-comparison check.
Nov 27 2018, 6:58 AM · Restricted Project
hwright updated the diff for D54737: [clang-tidy] Add the abseil-duration-comparison check.
Nov 27 2018, 6:57 AM · Restricted Project

Nov 26 2018

hwright added a comment to D54737: [clang-tidy] Add the abseil-duration-comparison check.

Sorry it's taken so long to get all the feedback addressed!

Nov 26 2018, 6:39 PM · Restricted Project
hwright updated the diff for D54737: [clang-tidy] Add the abseil-duration-comparison check.
Nov 26 2018, 6:39 PM · Restricted Project

Nov 19 2018

hwright created D54737: [clang-tidy] Add the abseil-duration-comparison check.
Nov 19 2018, 6:49 PM · Restricted Project

Nov 16 2018

hwright added a comment to D54246: [clang-tidy] Add the abseil-duration-factory-scale check.

@aaron.ballman I don't actually have the commit bit, can you commit this, or are we waiting for further review?

Nov 16 2018, 5:30 PM · Restricted Project
hwright added a comment to D54246: [clang-tidy] Add the abseil-duration-factory-scale check.

I think this is ready to go, please advise on next steps.

Nov 16 2018, 1:01 PM · Restricted Project
hwright added inline comments to D54246: [clang-tidy] Add the abseil-duration-factory-scale check.
Nov 16 2018, 12:59 PM · Restricted Project

Nov 14 2018

hwright added inline comments to D54246: [clang-tidy] Add the abseil-duration-factory-scale check.
Nov 14 2018, 7:30 AM · Restricted Project
hwright updated the diff for D54246: [clang-tidy] Add the abseil-duration-factory-scale check.

Combined multiplication and division logic, and also now handles scaling of multiple steps (e.g., Seconds * 3600).

Nov 14 2018, 7:29 AM · Restricted Project

Nov 12 2018

hwright added inline comments to D54246: [clang-tidy] Add the abseil-duration-factory-scale check.
Nov 12 2018, 10:51 AM · Restricted Project
hwright updated the diff for D54246: [clang-tidy] Add the abseil-duration-factory-scale check.

Addressed small concerns.

Nov 12 2018, 10:50 AM · Restricted Project

Nov 10 2018

hwright added inline comments to D54246: [clang-tidy] Add the abseil-duration-factory-scale check.
Nov 10 2018, 6:03 PM · Restricted Project
hwright updated the diff for D54246: [clang-tidy] Add the abseil-duration-factory-scale check.

Addressed reviewer feedback.

Nov 10 2018, 6:03 PM · Restricted Project

Nov 8 2018

hwright added inline comments to D54246: [clang-tidy] Add the abseil-duration-factory-scale check.
Nov 8 2018, 7:21 AM · Restricted Project
hwright updated the diff for D54246: [clang-tidy] Add the abseil-duration-factory-scale check.

Address reviewer comments

Nov 8 2018, 7:21 AM · Restricted Project

Nov 7 2018

hwright created D54246: [clang-tidy] Add the abseil-duration-factory-scale check.
Nov 7 2018, 5:26 PM · Restricted Project

Oct 24 2018

hwright added a comment to D53339: [clang-tidy] Add the abseil-duration-factory-float check.

I think accepted now? :)
If you want I can commit for you and monitor the buildbot, if there are bigger problems I would come back to you.

Oct 24 2018, 10:31 AM · Restricted Project
hwright updated the diff for D53339: [clang-tidy] Add the abseil-duration-factory-float check.

Remove full-stop

Oct 24 2018, 9:17 AM · Restricted Project
hwright added inline comments to D53339: [clang-tidy] Add the abseil-duration-factory-float check.
Oct 24 2018, 5:51 AM · Restricted Project
hwright updated the diff for D53339: [clang-tidy] Add the abseil-duration-factory-float check.

Update diagnostic text

Oct 24 2018, 4:18 AM · Restricted Project