This is an archive of the discontinued LLVM Phabricator instance.

Fix LLVM_LINK_LLVM_DYLIB build of TextAPI
ClosedPublic

Authored by sbc100 on Dec 10 2018, 11:32 AM.

Details

Summary

A dependency on TestingSupport was introduced in rL348735 including
it in LLVM_LINK_COMPONENTS rather than target_link_libraries seems
to break the LLVM_LINK_LLVM_DYLIB build.

Looking at other test targets it seems like target_link_libraries is the right
approach for including TestingSupport.

Diff Detail

Repository
rL LLVM

Event Timeline

sbc100 created this revision.Dec 10 2018, 11:32 AM
sbc100 edited the summary of this revision. (Show Details)Dec 10 2018, 11:34 AM
sbc100 added a reviewer: amontanez.
dschuff accepted this revision.Dec 10 2018, 2:01 PM

I don't 100% understand the distinction but if you've tested with LLVM_LINK_LLVM_DYLIB and BUILD_SHARED_LIBS and the static build then LGTM :)

This revision is now accepted and ready to land.Dec 10 2018, 2:01 PM
This revision was automatically updated to reflect the committed changes.