This is an archive of the discontinued LLVM Phabricator instance.

Fix bug where we'd try symbolize a second time with the same arguments.
ClosedPublic

Authored by delcypher on Dec 10 2018, 1:16 AM.

Details

Summary

Fix bug where we'd try symbolize a second time with the same arguments even though symbolization failed the first time.

This looks like a long standing typo given that the guard for trying
symbolization again is to only try it if symbolization failed using
binary and original_binary != binary.

Diff Detail

Repository
rL LLVM

Event Timeline

delcypher created this revision.Dec 10 2018, 1:16 AM
Herald added a subscriber: Restricted Project. · View Herald TranscriptDec 10 2018, 1:16 AM
vitalybuka accepted this revision.Dec 10 2018, 1:30 AM
This revision is now accepted and ready to land.Dec 10 2018, 1:30 AM
This revision was automatically updated to reflect the committed changes.