This is an archive of the discontinued LLVM Phabricator instance.

Differential D55477

[openmp] [cmake] Use -std=gnu++11 to fix alloca() on NetBSD
ClosedPublic

Authored by mgorny on Dec 8 2018, 8:34 AM.

Details

Reviewers
krytarowski
Hahnfeld
jlpeyton
Commits
rGe9d426727706: [cmake] Use -std=gnu++11 to fix alloca() on NetBSD
rOMP348854: [cmake] Use -std=gnu++11 to fix alloca() on NetBSD
rL348854: [cmake] Use -std=gnu++11 to fix alloca() on NetBSD
Summary

Prefer using '-std=gnu++11' over '-std=c++11' when available, as NetBSD
exposes the correct alloca() implementation only with gnu* C/C++
standards.

Diff Detail

Repository
rOMP OpenMP

Event Timeline

mgorny created this revision.Dec 8 2018, 8:34 AM
Herald added a subscriber: guansong. · View Herald TranscriptDec 8 2018, 8:34 AM
krytarowski accepted this revision.Dec 8 2018, 9:57 AM
This revision is now accepted and ready to land.Dec 8 2018, 9:57 AM
mgorny added a reviewer: jlpeyton.Dec 8 2018, 10:27 AM
Closed by commit rL348854: [cmake] Use -std=gnu++11 to fix alloca() on NetBSD (authored by mgorny). · Explain WhyDec 11 2018, 7:44 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptDec 11 2018, 7:44 AM

Revision Contents

PathSize
cmake/
5 lines
3 lines

Diff 177395

cmake/HandleOpenMPOptions.cmake

if (${OPENMP_STANDALONE_BUILD}) if (${OPENMP_STANDALONE_BUILD})
# From HandleLLVMOptions.cmake # From HandleLLVMOptions.cmake
function(append_if condition value) function(append_if condition value)
if (${condition}) if (${condition})
foreach(variable ${ARGN}) foreach(variable ${ARGN})
set(${variable} "${${variable}} ${value}" PARENT_SCOPE) set(${variable} "${${variable}} ${value}" PARENT_SCOPE)
endforeach(variable) endforeach(variable)
endif() endif()
endfunction() endfunction()
endif() endif()
if (${OPENMP_ENABLE_WERROR}) if (${OPENMP_ENABLE_WERROR})
append_if(OPENMP_HAVE_WERROR_FLAG "-Werror" CMAKE_C_FLAGS CMAKE_CXX_FLAGS) append_if(OPENMP_HAVE_WERROR_FLAG "-Werror" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)
endif() endif()
append_if(OPENMP_HAVE_STD_CPP11_FLAG "-std=c++11" CMAKE_CXX_FLAGS) append_if(OPENMP_HAVE_STD_GNUPP11_FLAG "-std=gnu++11" CMAKE_CXX_FLAGS)
No newline at end of file if (NOT OPENMP_HAVE_STD_GNUPP11_FLAG)
append_if(OPENMP_HAVE_STD_CPP11_FLAG "-std=c++11" CMAKE_CXX_FLAGS)
endif()

cmake/config-ix.cmake

include(CheckCCompilerFlag) include(CheckCCompilerFlag)
include(CheckCXXCompilerFlag) include(CheckCXXCompilerFlag)
check_c_compiler_flag(-Werror OPENMP_HAVE_WERROR_FLAG) check_c_compiler_flag(-Werror OPENMP_HAVE_WERROR_FLAG)
check_cxx_compiler_flag(-std=c++11 OPENMP_HAVE_STD_CPP11_FLAG) check_cxx_compiler_flag(-std=gnu++11 OPENMP_HAVE_STD_GNUPP11_FLAG)
No newline at end of file check_cxx_compiler_flag(-std=c++11 OPENMP_HAVE_STD_CPP11_FLAG)