Python 2/3 compat - socket server

[tstellar]

Is there a particular reason why this and https://reviews.llvm.org/D55259 are separate patches?

[serge-sans-paille]

Is there a particular reason why this and https://reviews.llvm.org/D55259 are separate patches?

The Python 2/3 portability is a huge patch. I have split it in several micro-patch, one for each package/feature impacted. The underlying idea is that we can keep the discussions focus. This package should just be a renaming issue, while https://reviews.llvm.org/D55259 uses a higher level API than the one before.

[gbedwell]

LGTM with one minor nit.

tools/scan-view/bin/scan-view

90 ↗

(On Diff #176572)

Minor nit. Elsewhere (E.g. D55202 and D55200), the pattern:

try:
    import py3name
except ImportError:
    import py2name as py3name

is used, so for consistency I'd suggest doing the same here (it also has the nice property of implying that Python 3 should be the 'real' version).

[serge-sans-paille]

Thanks @gbedwell for the review o/

cfe/trunk/tools/scan-view/bin/scan-view

try:
         httpd = ScanView.create_server((options.host, port),
                                        options, root)
         httpd.serve_forever()
     except KeyboardInterrupt:
         pass
 
 
 def port_is_open(port):
-    import SocketServer
     try:
-        t = SocketServer.TCPServer((kDefaultHost, port), None)
+        import socketserver
+    except ImportError:
+        import SocketServer as socketserver
+    try:
+        t = socketserver.TCPServer((kDefaultHost, port), None)
     except:
         return False
     t.server_close()
     return True
 
 
 def main():
     import argparse