This is an archive of the discontinued LLVM Phabricator instance.

[COFF] Don't mark mingw .eh_frame sections writable
ClosedPublic

Authored by mstorsjo on Dec 3 2018, 3:39 AM.

Details

Summary

This improves compatibility with GCC produced object files, where the .eh_frame sections are read only. With mixed flags for the involved .eh_frame sections, LLD creates two separate .eh_frame sections in the output binary, one for each flag combination, while ld.bfd probably merges them.

The previous setup of flags can be traced back to SVN r79346.

Diff Detail

Event Timeline

mstorsjo created this revision.Dec 3 2018, 3:39 AM
ruiu accepted this revision.Dec 3 2018, 8:33 AM

LGTM

This revision is now accepted and ready to land.Dec 3 2018, 8:33 AM
This revision was automatically updated to reflect the committed changes.
Allen added a subscriber: Allen.May 3 2022, 7:19 AM
Herald added projects: Restricted Project, Restricted Project. · View Herald TranscriptMay 3 2022, 7:19 AM