Page MenuHomePhabricator

[ARM64] [Windows] Fix the local stack size for funclets
ClosedPublic

Authored by ssijaric on Nov 29 2018, 5:16 PM.

Details

Summary

The comment was misplaced, and the code didn't do what the comment indicated, namely ignoring the varargs portion when computing the local stack size of a funclet in emitEpilogue. This results in incorrect offset computations within funclets that are contained in varag functions.

Diff Detail

Repository
rL LLVM

Event Timeline

ssijaric created this revision.Nov 29 2018, 5:16 PM
efriedma accepted this revision.Nov 29 2018, 5:27 PM
efriedma added a subscriber: efriedma.

LGTM

lib/Target/AArch64/AArch64FrameLowering.cpp
1292 ↗(On Diff #175998)

*containing.

This revision is now accepted and ready to land.Nov 29 2018, 5:27 PM
This revision was automatically updated to reflect the committed changes.