Page MenuHomePhabricator

[CMake] Fix standalone build for debugserver on macOS
ClosedPublic

Authored by sgraenitz on Nov 28 2018, 2:51 PM.

Details

Summary

Quick-fix to avoid CMake config issue:

CMake Error at /path/to/lldb/cmake/modules/AddLLDB.cmake:116 (add_dependencies):
  Cannot add target-level dependencies to non-existent target "lldb-suite".

Diff Detail

Repository
rL LLVM

Event Timeline

sgraenitz created this revision.Nov 28 2018, 2:51 PM
xiaobai accepted this revision.Nov 28 2018, 3:57 PM

This change looks fine to me. Have you considered creating something like a "debugserverStandalone.cmake" file similar to how LLDB standalone builds work? Might save us from some duplication, but I'm not sure if it would be overkill.

This revision is now accepted and ready to land.Nov 28 2018, 3:57 PM

Thought about it, but yes, at the moment it looks like overkill. I'd go on duplicating options to debugserver for now and change the approach if it gets unpractical. There are some more changes to come. I want to upstream these first and see how it looks then.

This revision was automatically updated to reflect the committed changes.