This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Update docs
ClosedPublic

Authored by sbc100 on Nov 27 2018, 3:47 PM.

Details

Summary

This is an reland of rL343155 which got reverted because
of a sphinx failure on the buildbot.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

sbc100 created this revision.Nov 27 2018, 3:47 PM
sbc100 added a reviewer: ruiu.Nov 27 2018, 3:48 PM
ruiu added inline comments.Nov 28 2018, 11:30 AM
docs/WebAssembly.rst
48

a -> an

54

Add a full stop.

58

Disable

62

Full stop.

66

This might be too brief. I'd also mention that this option should be used when you are creating a release version of a binary.

70

Full stop. I think you should mention that this is mostly for debugging and should not be used for a release version of binary.

74

Full stop.

78

Full stop.

93

un-used -> unused

sbc100 updated this revision to Diff 175784.Nov 28 2018, 4:12 PM
  • feedback
ruiu accepted this revision.Nov 28 2018, 4:26 PM

LGTM

docs/WebAssembly.rst
58

There is a typo

Disble ->Disable

This revision is now accepted and ready to land.Nov 28 2018, 4:26 PM
This revision was automatically updated to reflect the committed changes.