There is no advantage in having them in separate files, I doubt some will ever use them separately.
This also makes it easier to move the API to LLVM.
Differential D54977
[analyzer] Moved the whole SMT API to a single file. NFC. mikhail.ramalho on Nov 27 2018, 2:35 PM. Authored by
Details There is no advantage in having them in separate files, I doubt some will ever use them separately. This also makes it easier to move the API to LLVM.
Diff Detail
Event TimelineComment Actions The advantage is it's easier to find stuff with a 1-1 correspondence between class names and files. Comment Actions I agree that having separate files helps but I'll send the other backends in the future, adding even more files. I was trying to reduce the clutter. Do you think I should put everything in a separate directory instead? Comment Actions I don't mind, it's entirely a matter of taste, as far as i understand. Please feel free to make it as comfortable for yourself as possible. Generally people are annoyed a bit by this sort of commits because when you move things around git blames get screwed. |