This is an archive of the discontinued LLVM Phabricator instance.

AMDGPU: Record SGPR spills when restoring too
ClosedPublic

Authored by arsenm on Nov 26 2018, 11:37 AM.

Details

Reviewers
rampitec
Summary

It's possible in some cases to have a restore present without a corresponding spill. Due to an apparent bug in D54366, only the restore for a register was emitted. It's probably always a bug for this to happen, but due to how SGPR spilling is implemented, this makes the issues appear worse than it is.

Diff Detail

Event Timeline

arsenm created this revision.Nov 26 2018, 11:37 AM
This revision is now accepted and ready to land.Nov 26 2018, 11:48 AM
arsenm closed this revision.Nov 26 2018, 1:31 PM

r347595