Page MenuHomePhabricator

[AMDGPU] An exp must be branched over if exec=0
AbandonedPublic

Authored by tpr on Nov 23 2018, 4:11 AM.

Details

Reviewers
nhaehnle
arsenm
Summary

Change-Id: I1f57e70da08c08fe65917d762d82ba28251a5b5b

Diff Detail

Event Timeline

tpr created this revision.Nov 23 2018, 4:11 AM
arsenm accepted this revision.Nov 23 2018, 1:43 PM

LGTM

This revision is now accepted and ready to land.Nov 23 2018, 1:43 PM

This should already be fixed in trunk. Trunk has a function TII->hasUnwantedEffectsWhenEXECEmpty to cover this, and this patch simply shouldn't apply.

I vaguely recall you complained about those changes I made and backed them out of the Vulkan branch because of some pixel shader case where some bad lowering happened? I don't remember the details right now.

tpr abandoned this revision.Nov 28 2018, 7:03 AM

Yes, sorry, I pushed this fix to phab without even checking that it applies to trunk. I had completely forgotten that you have already fixed this in trunk (D48431) and I reverted your fix in our local branch.