[WebAssembly] Make starting indices calcaulation simpler (NFC)

[aheejin]

Summary

At the beginning of assignIndexes() function, when FunctionIndex` and
GlobalIndex variables are created, InputFunctions and InputGlobals
vectors are guaranteed to be empty, because those vectors are only
populated in assignIndexes() function. Current code looks like they
are nonempty, so this patch deletes them for better readability.

[sbc100]

Hmm, I guess at some point in the past InputFunctions and InputGlobals were not empty at the start of this function.

Can you add asserts that they are empty?

[aheejin]

• Add assertions

lld/trunk/wasm/Writer.cpp

for (const Symbol *Sym : ImportedSymbols)
     if (auto *F = dyn_cast<FunctionSymbol>(Sym))
       registerType(*F->FunctionType);
 
   for (const InputFunction *F : InputFunctions)
     registerType(F->Signature);
 }
 
 void Writer::assignIndexes() {
-  uint32_t FunctionIndex = NumImportedFunctions + InputFunctions.size();
+  assert(InputFunctions.empty());
+  uint32_t FunctionIndex = NumImportedFunctions;
   auto AddDefinedFunction = [&](InputFunction *Func) {
     if (!Func->Live)
       return;
     InputFunctions.emplace_back(Func);
     Func->setFunctionIndex(FunctionIndex++);
   };
 
   for (InputFunction *Func : Symtab->SyntheticFunctions)
for (ObjFile *File : Symtab->ObjectFiles) {
     for (InputChunk *Chunk : File->Functions)
       HandleRelocs(Chunk);
     for (InputChunk *Chunk : File->Segments)
       HandleRelocs(Chunk);
     for (auto &P : File->CustomSections)
       HandleRelocs(P);
   }
 
-  uint32_t GlobalIndex = NumImportedGlobals + InputGlobals.size();
+  assert(InputGlobals.empty());
+  uint32_t GlobalIndex = NumImportedGlobals;
   auto AddDefinedGlobal = [&](InputGlobal *Global) {
     if (Global->Live) {
       LLVM_DEBUG(dbgs() << "AddDefinedGlobal: " << GlobalIndex << "\n");
       Global->setGlobalIndex(GlobalIndex++);
       InputGlobals.push_back(Global);
     }
   };