Page MenuHomePhabricator

RegisterCoalescer: Defer clearing implicit_def lanes
ClosedPublic

Authored by arsenm on Nov 15 2018, 8:58 PM.

Details

Summary

We can't go back and recover the lanes if it turns
out the implicit_def really can't be erased.

Assume all lanes are valid if an unresolved conflict
is encountered. There aren't any tests where this
seems to matter either way, but this seems like a
safer option.

Fixes bug 39602

Diff Detail

Event Timeline

arsenm created this revision.Nov 15 2018, 8:58 PM
arsenm updated this revision to Diff 174326.Nov 15 2018, 9:00 PM

Add testcase for the second case where ErasableImplicitDef is cleared, although the used lanes don't matter

arsenm added a reviewer: wmi.Dec 12 2018, 7:18 PM
This revision is now accepted and ready to land.Jan 8 2019, 10:50 AM
arsenm closed this revision.Jan 8 2019, 3:14 PM

r350676