This is an archive of the discontinued LLVM Phabricator instance.

Differential D54613

[CMake] Use the correct spelling for armv7 in Fuchsia's toolchain
ClosedPublic

Authored by phosek on Nov 15 2018, 7:59 PM.

Details

Reviewers
mcgrathr
jakehehrlich
juliehockett
Commits
rG1ee2987abcc3: [CMake] Use the correct spelling for armv7 in Fuchsia's toolchain
rL347021: [CMake] Use the correct spelling for armv7 in Fuchsia's toolchain
rC347021: [CMake] Use the correct spelling for armv7 in Fuchsia's toolchain
Summary

We need to explicitly specify the architecture version.

Diff Detail

Repository
rC Clang

Event Timeline

phosek created this revision.Nov 15 2018, 7:59 PM
Herald added subscribers: Restricted Project, llvm-commits, chrib and 2 others. · View Herald TranscriptNov 15 2018, 7:59 PM
mcgrathr accepted this revision.Nov 15 2018, 8:04 PM

lgtm

This revision is now accepted and ready to land.Nov 15 2018, 8:04 PM
Closed by commit rC347021: [CMake] Use the correct spelling for armv7 in Fuchsia's toolchain (authored by phosek). · Explain WhyNov 15 2018, 8:12 PM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: cfe-commits. · View Herald TranscriptNov 15 2018, 8:12 PM

Revision Contents

PathSize
cmake/
caches/
2 lines

Diff 174319

cmake/caches/Fuchsia-stage2.cmake

Show All 27 Lines
set(CMAKE_C_FLAGS_RELWITHDEBINFO "-O3 -gline-tables-only -DNDEBUG" CACHE STRING "") set(CMAKE_C_FLAGS_RELWITHDEBINFO "-O3 -gline-tables-only -DNDEBUG" CACHE STRING "")
set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O3 -gline-tables-only -DNDEBUG" CACHE STRING "") set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O3 -gline-tables-only -DNDEBUG" CACHE STRING "")
if(APPLE) if(APPLE)
list(APPEND BUILTIN_TARGETS "default") list(APPEND BUILTIN_TARGETS "default")
list(APPEND RUNTIME_TARGETS "default") list(APPEND RUNTIME_TARGETS "default")
endif() endif()
foreach(target i386-linux-gnu;x86_64-linux-gnu;arm-linux-gnueabi;aarch64-linux-gnu) foreach(target aarch64-linux-gnu;armv7-linux-gnueabihf;i386-linux-gnu;x86_64-linux-gnu)
if(LINUX_${target}_SYSROOT) if(LINUX_${target}_SYSROOT)
# Set the per-target builtins options. # Set the per-target builtins options.
list(APPEND BUILTIN_TARGETS "${target}") list(APPEND BUILTIN_TARGETS "${target}")
set(BUILTINS_${target}_CMAKE_SYSTEM_NAME Linux CACHE STRING "") set(BUILTINS_${target}_CMAKE_SYSTEM_NAME Linux CACHE STRING "")
set(BUILTINS_${target}_CMAKE_BUILD_TYPE Release CACHE STRING "") set(BUILTINS_${target}_CMAKE_BUILD_TYPE Release CACHE STRING "")
set(BUILTINS_${target}_CMAKE_SYSROOT ${LINUX_${target}_SYSROOT} CACHE STRING "") set(BUILTINS_${target}_CMAKE_SYSROOT ${LINUX_${target}_SYSROOT} CACHE STRING "")
set(BUILTINS_${target}_CMAKE_SHARED_LINKER_FLAGS "-fuse-ld=lld" CACHE STRING "") set(BUILTINS_${target}_CMAKE_SHARED_LINKER_FLAGS "-fuse-ld=lld" CACHE STRING "")
set(BUILTINS_${target}_CMAKE_MODULE_LINKER_FLAGS "-fuse-ld=lld" CACHE STRING "") set(BUILTINS_${target}_CMAKE_MODULE_LINKER_FLAGS "-fuse-ld=lld" CACHE STRING "")
▲ Show 20 Lines • Show All 125 Lines • Show Last 20 Lines