This is an archive of the discontinued LLVM Phabricator instance.

Differential D54573

[llvm-objdump] Use `auto` declaration in typecasting
ClosedPublic

Authored by Higuoxing on Nov 15 2018, 3:29 AM.

Details

Reviewers
jhenderson
MaskRay
Commits
rGcc0829f3cbb3: [llvm-objdump] Use `auto` declaration in typecasting
rL346946: [llvm-objdump] Use `auto` declaration in typecasting
Summary

According to MaskRay, use auto for type inference, according to coding standards.
Delete some comments, because these comments can be easily inferred from codes.

Diff Detail

Event Timeline

Higuoxing created this revision.Nov 15 2018, 3:29 AM
Herald added a subscriber: llvm-commits. · View Herald TranscriptNov 15 2018, 3:29 AM
Harbormaster completed remote builds in B25039: Diff 174177.Nov 15 2018, 3:29 AM
jhenderson accepted this revision.Nov 15 2018, 3:52 AM

LGTM.

This revision is now accepted and ready to land.Nov 15 2018, 3:52 AM
Closed by commit rL346946: [llvm-objdump] Use `auto` declaration in typecasting (authored by Higuoxing). · Explain WhyNov 15 2018, 3:53 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
tools/
llvm-objdump/
24 lines

Diff 174177

tools/llvm-objdump/ELFDump.cpp

Show First 20 Lines • Show All 152 Lines • ▼ Show 20 Lines outs() << "off " << format(Fmt, (uint64_t)Phdr.p_offset) << "vaddr "
<< ((Phdr.p_flags & ELF::PF_R) ? "r" : "-") << ((Phdr.p_flags & ELF::PF_R) ? "r" : "-")
<< ((Phdr.p_flags & ELF::PF_W) ? "w" : "-") << ((Phdr.p_flags & ELF::PF_W) ? "w" : "-")
<< ((Phdr.p_flags & ELF::PF_X) ? "x" : "-") << "\n"; << ((Phdr.p_flags & ELF::PF_X) ? "x" : "-") << "\n";
} }
outs() << "\n"; outs() << "\n";
} }
void llvm::printELFFileHeader(const object::ObjectFile *Obj) { void llvm::printELFFileHeader(const object::ObjectFile *Obj) {
// Little-endian 32-bit if (const auto *ELFObj = dyn_cast<ELF32LEObjectFile>(Obj))
if (const ELF32LEObjectFile *ELFObj = dyn_cast<ELF32LEObjectFile>(Obj))
printProgramHeaders(ELFObj->getELFFile()); printProgramHeaders(ELFObj->getELFFile());
// Big-endian 32-bit else if (const auto *ELFObj = dyn_cast<ELF32BEObjectFile>(Obj))
else if (const ELF32BEObjectFile *ELFObj = dyn_cast<ELF32BEObjectFile>(Obj))
printProgramHeaders(ELFObj->getELFFile()); printProgramHeaders(ELFObj->getELFFile());
// Little-endian 64-bit else if (const auto *ELFObj = dyn_cast<ELF64LEObjectFile>(Obj))
else if (const ELF64LEObjectFile *ELFObj = dyn_cast<ELF64LEObjectFile>(Obj))
printProgramHeaders(ELFObj->getELFFile()); printProgramHeaders(ELFObj->getELFFile());
// Big-endian 64-bit else if (const auto *ELFObj = dyn_cast<ELF64BEObjectFile>(Obj))
else if (const ELF64BEObjectFile *ELFObj = dyn_cast<ELF64BEObjectFile>(Obj))
printProgramHeaders(ELFObj->getELFFile()); printProgramHeaders(ELFObj->getELFFile());
} }
void llvm::printELFDynamicSection(const object::ObjectFile *Obj) { void llvm::printELFDynamicSection(const object::ObjectFile *Obj) {
// Little-endian 32-bit if (const auto *ELFObj = dyn_cast<ELF32LEObjectFile>(Obj))
if (const ELF32LEObjectFile *ELFObj = dyn_cast<ELF32LEObjectFile>(Obj))
printDynamicSection(ELFObj->getELFFile(), Obj->getFileName()); printDynamicSection(ELFObj->getELFFile(), Obj->getFileName());
// Big-endian 32-bit else if (const auto *ELFObj = dyn_cast<ELF32BEObjectFile>(Obj))
else if (const ELF32BEObjectFile *ELFObj = dyn_cast<ELF32BEObjectFile>(Obj))
printDynamicSection(ELFObj->getELFFile(), Obj->getFileName()); printDynamicSection(ELFObj->getELFFile(), Obj->getFileName());
// Little-endian 64-bit else if (const auto *ELFObj = dyn_cast<ELF64LEObjectFile>(Obj))
else if (const ELF64LEObjectFile *ELFObj = dyn_cast<ELF64LEObjectFile>(Obj))
printDynamicSection(ELFObj->getELFFile(), Obj->getFileName()); printDynamicSection(ELFObj->getELFFile(), Obj->getFileName());
// Big-endian 64-bit else if (const auto *ELFObj = dyn_cast<ELF64BEObjectFile>(Obj))
else if (const ELF64BEObjectFile *ELFObj = dyn_cast<ELF64BEObjectFile>(Obj))
printDynamicSection(ELFObj->getELFFile(), Obj->getFileName()); printDynamicSection(ELFObj->getELFFile(), Obj->getFileName());
} }