This is an archive of the discontinued LLVM Phabricator instance.

[AST] Generate unique identifiers for CXXCtorInitializer objects.
ClosedPublic

Authored by NoQ on Nov 12 2018, 5:19 PM.

Details

Summary

This follows D51822 and D52113 to add a cheap way of obtaining a unique and relatively stable* numeric identifier for CXXCtorInitializers.

__
*I.e., reproducible across runs but not necessarily across different host machines.

Diff Detail

Event Timeline

NoQ created this revision.Nov 12 2018, 5:19 PM
george.karpenkov accepted this revision.Nov 12 2018, 5:20 PM
george.karpenkov added inline comments.
lib/AST/DeclCXX.cpp
2249

Should we factor out this code? It's a fourth duplication now, probably a generic form should be in the allocator.

This revision is now accepted and ready to land.Nov 12 2018, 5:20 PM
NoQ updated this revision to Diff 176465.Dec 3 2018, 1:17 PM

Rebase on top of D54486!

NoQ marked an inline comment as done.Dec 3 2018, 1:18 PM
NoQ updated this revision to Diff 176470.Dec 3 2018, 1:51 PM

Wait, i already did that in D54488.

This revision was automatically updated to reflect the committed changes.