This is an archive of the discontinued LLVM Phabricator instance.

Fixed DAGTypeLegalizer::SplitVecOp_EXTRACT_VECTOR_ELT i1 handling
ClosedPublic

Authored by rampitec on Nov 12 2018, 12:51 PM.

Details

Summary

Legalizer used to request an ext load from i8 to i1 when promoting
vector element type to i8. Fixed.

Diff Detail

Event Timeline

rampitec created this revision.Nov 12 2018, 12:51 PM
rampitec updated this revision to Diff 173750.Nov 12 2018, 1:32 PM

Added stripped test (a relevant portion) from D54351.

rampitec edited the summary of this revision. (Show Details)Nov 12 2018, 1:32 PM

I’m not sure this will use the right memory layout

rampitec added a comment.EditedNov 12 2018, 3:19 PM

I’m not sure this will use the right memory layout

If you look at line 1922 it just uses i8 regardless. This might be a separate issue. The issue addressed here is when an extload requested from wider to a narrower type.

arsenm accepted this revision.Nov 13 2018, 9:00 AM

LGTM, but add a fixme since something will be necessary

This revision is now accepted and ready to land.Nov 13 2018, 9:00 AM
rampitec updated this revision to Diff 173870.Nov 13 2018, 9:40 AM

Added comment.

This revision was automatically updated to reflect the committed changes.