This is an archive of the discontinued LLVM Phabricator instance.

[llvm-exegesis][NFC] Some code style cleanup
ClosedPublic

Authored by jsji on Nov 9 2018, 12:14 PM.

Details

Summary

Apply review comments of https://reviews.llvm.org/D54185 to other target as well, specifically:

  1. make anonymous namespaces as small as possible, avoid using static inside anonymous namespaces
  2. Add missing header to some files
  3. GetLoadImmediateOpcodem-> getLoadImmediateOpcode
  4. Fix typo

Diff Detail

Event Timeline

jsji created this revision.Nov 9 2018, 12:14 PM
gchatelet added inline comments.Nov 11 2018, 11:39 PM
llvm/tools/llvm-exegesis/lib/X86/Target.cpp
333

newline between constant and functions.

337

newline between functions.

338

newline between functions and members.

420

newline between functions.

llvm/unittests/tools/llvm-exegesis/AArch64/TargetTest.cpp
1

Thx!

jsji updated this revision to Diff 173669.Nov 12 2018, 7:11 AM
jsji marked 4 inline comments as done.

Address comments about newline among functions.

jsji added a comment.Nov 19 2018, 6:43 AM

@gchatelet Gentle ping? Any further comments? Thanks.

gchatelet accepted this revision.Nov 20 2018, 1:18 AM
gchatelet added inline comments.
llvm/tools/llvm-exegesis/lib/X86/Target.cpp
338

newline after constant.

This revision is now accepted and ready to land.Nov 20 2018, 1:18 AM
jsji marked an inline comment as done.Nov 20 2018, 6:41 AM
This revision was automatically updated to reflect the committed changes.